On Thu, Feb 10, 2011 at 04:07:09PM -0800, Ian Main wrote:
On Thu, Feb 10, 2011 at 04:53:00PM +0100, Jan Provaznik wrote:
> On 02/10/2011 03:01 PM, jzigmund(a)redhat.com wrote:
> > From: Jozef Zigmund<jzigmund(a)redhat.com>
> >
> > Inside this patch I rename model of CloudAccount to ProviderAccount. Also I
refactor all codes where this model was called. All supported providers are included in
constant hash, that is named PROVIDER_TYPES in Provider model. So now, attribute of class
"cloud_type" is renamed to "provider_type" and it must be one of these
PROVIDER_TYPES value. I fixed all Rspecs and Cucumbers for provider_account model.
> >
> > In this revision added fixing failing rspec in next.
> >
> > When you'll test this patch won't forget to run "rake
db:migrate", because some of the attributes were changed in DB.
>
> ACK with notes:
> - bad font in providers_account new form
> - still commented out set_provider_type everywhere (should be deleted)
> - delete set_provider_type from features/support/custom.rb
> - "previous_provider_type = @provider" line in providers_controller
> seems to be useless, should be deleted
> - disable/remove provider type selection field in provider account edit
> form (drops all valued, loads new form)
>
> Jan
This patch broke condor_refreshd:
/usr/share/deltacloud-aggregator/app/util/condormatic.rb:253:in
`condormatic_classads_sync': undefined method `name' for nil:NilClass
from /usr/share/deltacloud-aggregator/app/util/condormatic.rb:233:in `each'
from /usr/share/deltacloud-aggregator/app/util/condormatic.rb:233:in
`condormatic_classads_sync'
from ./condor_refreshd:104
Bleh, sorry guys. It seems that somehow I managed to create an account
without the keypair being generated?? Anyway I did a fresh install and
it seems to work now. This did show a bug in condor_refreshd though..
it was creating zombie processes and making everything else break.
I also did not mean to single you guys out, we should all be doing end
to end testing for our patches. I'm just feeling frustrated by all the
bugs this time around.
Ian
Please do full end to end testing, including creating an ec2
instance(!!),
and verify that the db gets updated correctly etc after creating a
patch like this. We should really be doing it every time but especially
for something this big. Both the developer AND the ACK'er should BOTH have
tested this end to end before pushing/acking.