[copr] master: C:158, 0: Unnecessary parens after 'not' keyword (superfluous-parens) (e47f637)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit e47f63704c163d3510a6932018da55697433d76d
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:11:54 2014 +0200
C:158, 0: Unnecessary parens after 'not' keyword (superfluous-parens)
>---------------------------------------------------------------
.../coprs_frontend/coprs/logic/builds_logic.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/logic/builds_logic.py b/frontend/coprs_frontend/coprs/logic/builds_logic.py
index cc8b651..dde205e 100644
--- a/frontend/coprs_frontend/coprs/logic/builds_logic.py
+++ b/frontend/coprs_frontend/coprs/logic/builds_logic.py
@@ -155,7 +155,7 @@ class BuildsLogic(object):
@classmethod
def delete_build(cls, user, build):
- if not (user.can_build_in(build.copr)):
+ if not user.can_build_in(build.copr):
raise exceptions.InsufficientRightsException(
"You are not allowed to delete this build.")
9 years, 11 months
[copr] master: W:154, 0: Unnecessary semicolon (unnecessary-semicolon) (8a8c25d)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 8a8c25db7c4a2b704122ca9e9e361966d1c4e446
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:11:20 2014 +0200
W:154, 0: Unnecessary semicolon (unnecessary-semicolon)
>---------------------------------------------------------------
.../coprs_frontend/coprs/logic/builds_logic.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/logic/builds_logic.py b/frontend/coprs_frontend/coprs/logic/builds_logic.py
index 359b912..cc8b651 100644
--- a/frontend/coprs_frontend/coprs/logic/builds_logic.py
+++ b/frontend/coprs_frontend/coprs/logic/builds_logic.py
@@ -151,7 +151,7 @@ class BuildsLogic(object):
"You are not allowed to cancel this build.")
build.canceled = True
for chroot in build.build_chroots:
- chroot.status = 2; #canceled
+ chroot.status = 2 #canceled
@classmethod
def delete_build(cls, user, build):
9 years, 11 months
[copr] master: C:149, 0: Unnecessary parens after 'not' keyword (superfluous-parens) (54c932c)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 54c932ce4c25c8816ef71ad120b48e7349ec67c5
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:10:24 2014 +0200
C:149, 0: Unnecessary parens after 'not' keyword (superfluous-parens)
>---------------------------------------------------------------
.../coprs_frontend/coprs/logic/builds_logic.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/logic/builds_logic.py b/frontend/coprs_frontend/coprs/logic/builds_logic.py
index d4961fc..359b912 100644
--- a/frontend/coprs_frontend/coprs/logic/builds_logic.py
+++ b/frontend/coprs_frontend/coprs/logic/builds_logic.py
@@ -146,7 +146,7 @@ class BuildsLogic(object):
@classmethod
def cancel_build(cls, user, build):
- if not (user.can_build_in(build.copr)):
+ if not user.can_build_in(build.copr):
raise exceptions.InsufficientRightsException(
"You are not allowed to cancel this build.")
build.canceled = True
9 years, 11 months
[copr] master: C:265, 0: Exactly one space required around assignment (8ab2d63)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 8ab2d6363c0a8cc148de309ed2c19fbecd2e9bb9
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:03:47 2014 +0200
C:265, 0: Exactly one space required around assignment
pkgs=form.pkgs.data.replace('\n', ' ').split(" ")
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index b253c1e..fc7375a 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -262,7 +262,7 @@ def copr_new_build(username, coprname):
elif form.validate_on_submit() and flask.g.user.can_build_in(copr):
# we're checking authorization above for now
# and also creating separate build for each package
- pkgs=form.pkgs.data.replace('\n', ' ').split(" ")
+ pkgs = form.pkgs.data.replace('\n', ' ').split(" ")
ids = []
chroots = []
for chroot in copr.active_chroots:
9 years, 11 months
[copr] master: C:128, 0: No space allowed around keyword argument assignment (02fa6d8)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 02fa6d8b295a5d29e16897a076c1246a4508ee60
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:01:26 2014 +0200
C:128, 0: No space allowed around keyword argument assignment
chroots = chroots)
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_builds.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
index 02ee60d..c6c61f3 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
@@ -125,7 +125,7 @@ def copr_new_build(username, coprname):
user=flask.g.user,
pkgs=pkg,
copr=copr,
- chroots = chroots)
+ chroots=chroots)
if flask.g.user.proven:
build.memory_reqs = form.memory_reqs.data
9 years, 11 months
[copr] master: get rid of multi assigment (a571a28)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit a571a2834107c74c94f47a1b07ae0344dd51446d
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 19:00:48 2014 +0200
get rid of multi assigment
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_builds.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
index 243e1c7..02ee60d 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
@@ -98,7 +98,7 @@ def copr_new_build(username, coprname):
form = forms.BuildFormFactory.create_form_cls(copr.active_chroots)()
if form.validate_on_submit():
- pkgs = pkgs=form.pkgs.data.replace("\n", " ").split(" ")
+ pkgs = form.pkgs.data.replace("\n", " ").split(" ")
# validate (and skip bad) urls
bad_urls = []
9 years, 11 months
[copr] master: C: 50, 0: Trailing whitespace (trailing-whitespace) (186bfe7)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 186bfe71045c8db16fef27697fc96578c5efc08a
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:56:33 2014 +0200
C: 50, 0: Trailing whitespace (trailing-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_builds.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
index 0f35c18..243e1c7 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
@@ -49,7 +49,6 @@ def copr_build(username, coprname, build_id):
copr=copr)
-
@coprs_ns.route("/<username>/<coprname>/builds/", defaults={"page": 1})
@coprs_ns.route("/<username>/<coprname>/builds/<int:page>/")
def copr_builds(username, coprname, page=1):
9 years, 11 months
[copr] master: C: 27, 0: No space allowed around keyword argument assignment (019fe69)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 019fe69745525ddf86b4f6b40d126974dbb0b2b6
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:55:15 2014 +0200
C: 27, 0: No space allowed around keyword argument assignment
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_builds.py | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
index a39f291..0f35c18 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_builds.py
@@ -24,9 +24,9 @@ def copr_build_redirect(build_id):
"Build {0} does not exist.".format(str(build_id)))
return flask.redirect(flask.url_for("coprs_ns.copr_build",
- username = build.copr.owner.name,
- coprname = build.copr.name,
- build_id = build_id))
+ username=build.copr.owner.name,
+ coprname=build.copr.name,
+ build_id=build_id))
@coprs_ns.route("/<username>/<coprname>/build/<int:build_id>/")
@@ -40,13 +40,13 @@ def copr_build(username, coprname, build_id):
if not copr: # but the build does
return flask.render_template("coprs/detail/build-no-project.html",
- build = build,
- username = username,
- coprname = coprname)
+ build=build,
+ username=username,
+ coprname=coprname)
return flask.render_template("coprs/detail/build.html",
- build = build,
- copr = copr)
+ build=build,
+ copr=copr)
9 years, 11 months
[copr] master: C:575, 0: No space allowed around keyword argument assignment chroots=chroots, oses=oses_grouped, archs = archs, ^ (bad-whitespace) (e5994a5)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit e5994a50144484da08d81411a11daf727d3fb0e2
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:47:06 2014 +0200
C:575, 0: No space allowed around keyword argument assignment
chroots=chroots, oses=oses_grouped, archs = archs,
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index d20ec6c..8c1cd16 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -572,6 +572,6 @@ def copr_build_monitor(username, coprname):
return flask.render_template("coprs/detail/monitor.html",
copr=copr,
build=latest_build,
- chroots=chroots, oses=oses_grouped, archs = archs,
+ chroots=chroots, oses=oses_grouped, archs=archs,
packages=sorted(out.iteritems()),
form=form)
9 years, 11 months
[copr] master: C:575, 0: No space allowed around keyword argument assignment (94b415a)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 94b415a609d55859f7e328bfe4085755bb273243
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:45:32 2014 +0200
C:575, 0: No space allowed around keyword argument assignment
chroots=chroots, oses = oses_grouped, archs = archs,
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index e13c44b..d20ec6c 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -572,6 +572,6 @@ def copr_build_monitor(username, coprname):
return flask.render_template("coprs/detail/monitor.html",
copr=copr,
build=latest_build,
- chroots=chroots, oses = oses_grouped, archs = archs,
+ chroots=chroots, oses=oses_grouped, archs = archs,
packages=sorted(out.iteritems()),
form=form)
9 years, 11 months