[copr] master: C:542, 0: Exactly one space required after comma (50124c2)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 50124c281c160df0afafd2a78cb4195d38a03657
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:43:47 2014 +0200
C:542, 0: Exactly one space required after comma
oses_grouped = [(len(list(group)),key) for key, group in groupby(oses)]
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index fdf138f..e13c44b 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -539,7 +539,7 @@ def copr_build_monitor(username, coprname):
build = None
chroots = set([chroot.name for chroot in copr.active_chroots])
oses = [chroot.os for chroot in copr.active_chroots]
- oses_grouped = [(len(list(group)),key) for key, group in groupby(oses)]
+ oses_grouped = [(len(list(group)), key) for key, group in groupby(oses)]
archs = [chroot.arch for chroot in copr.active_chroots]
latest_build = None
9 years, 11 months
[copr] master: C:365, 0: Exactly one space required after comma s.sendmail("root@{0}".format(platform.node()), perm.user.mail , msg.as_string()) ^ (bad-whitespace) C:365, 0: No space allowed before comma s.sendmail("root@{0}".format(platform.node()), perm.user.mail , msg.as_string()) ^ (bad-whitespace) (6501dc0)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 6501dc00891e72c3b1e003720427a3e2a84ba791
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:42:39 2014 +0200
C:365, 0: Exactly one space required after comma
s.sendmail("root@{0}".format(platform.node()),perm.user.mail , msg.as_string())
^ (bad-whitespace)
C:365, 0: No space allowed before comma
s.sendmail("root@{0}".format(platform.node()),perm.user.mail , msg.as_string())
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index f9611de..fdf138f 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -362,7 +362,7 @@ def copr_update_permissions(username, coprname):
msg["From"] = "root@{0}".format(platform.node())
msg["To"] = perm.user.mail
s = smtplib.SMTP("localhost")
- s.sendmail("root@{0}".format(platform.node()),perm.user.mail , msg.as_string())
+ s.sendmail("root@{0}".format(platform.node()), perm.user.mail, msg.as_string())
s.quit()
# for now, we don't check for actions here, as permissions operation
9 years, 11 months
[copr] master: C:316, 0: No space allowed before comma s.sendmail("root@{0}".format(platform.node()), mail , msg.as_string()) ^ (bad-whitespace) (94318de)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 94318de89420c1de19c5c5af08a26ae1af03b165
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:41:09 2014 +0200
C:316, 0: No space allowed before comma
s.sendmail("root@{0}".format(platform.node()), mail , msg.as_string())
^ (bad-whitespace)
>---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index 3646305..f9611de 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -313,7 +313,7 @@ def copr_permissions_applier_change(username, coprname):
msg["From"] = "root@{0}".format(platform.node())
msg["To"] = mail
s = smtplib.SMTP("localhost")
- s.sendmail("root@{0}".format(platform.node()), mail , msg.as_string())
+ s.sendmail("root@{0}".format(platform.node()), mail, msg.as_string())
s.quit()
9 years, 11 months
[copr] master: W:310, 8: Attribute 'abort' defined outside __init__ (attribute-defined-outside-init) (7eca4a3)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 7eca4a3ab1991e1481c8337d64133e749de7c9f3
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:32:54 2014 +0200
W:310, 8: Attribute 'abort' defined outside __init__ (attribute-defined-outside-init)
>---------------------------------------------------------------
backend/copr-be.py | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/backend/copr-be.py b/backend/copr-be.py
index c0280a8..f331513 100755
--- a/backend/copr-be.py
+++ b/backend/copr-be.py
@@ -199,6 +199,7 @@ class CoprBackend(object):
self._jobgrab = CoprJobGrab(self.opts, self.events, self.jobs, self.lock)
self._jobgrab.start()
self.worker_num = 0
+ self.abort = False
if not os.path.exists(self.opts.worker_logdir):
os.makedirs(self.opts.worker_logdir, mode=0750)
9 years, 11 months
[copr] master: W:139, 0: Dangerous default value [] as argument (dangerous-default-value) W:139, 0: Dangerous default value [0] as argument (dangerous-default-value) W:139, 0: Dangerous default value ['stdout', 'stderr'] as argument (dangerous-default-value) (ec8aec1)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit ec8aec1b68041b345149776020925a6df3e7f93c
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:23:56 2014 +0200
W:139, 0: Dangerous default value [] as argument (dangerous-default-value)
W:139, 0: Dangerous default value [0] as argument (dangerous-default-value)
W:139, 0: Dangerous default value ['stdout', 'stderr'] as argument (dangerous-default-value)
>---------------------------------------------------------------
backend/backend/mockremote.py | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index d36da87..85954cd 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -136,14 +136,20 @@ def _create_ans_conn(hostname, username, timeout):
return ans_conn
-def check_for_ans_error(results, hostname, err_codes=[], success_codes=[0],
- return_on_error=["stdout", "stderr"]):
+def check_for_ans_error(results, hostname, err_codes=None, success_codes=None,
+ return_on_error=None):
"""
Return True or False + dict
dict includes 'msg'
may include 'rc', 'stderr', 'stdout' and any other requested result codes
"""
+ if err_codes is None:
+ err_codes = []
+ if success_codes is None:
+ success_codes = [0]
+ if return_on_error is None:
+ return_on_error = ["stdout", "stderr"]
err_results = {}
if "dark" in results and hostname in results["dark"]:
9 years, 11 months
[copr] master: W:543, 4: Dangerous default value DEF_MACROS ({}) as argument (dangerous-default-value) (11d14c8)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 11d14c809fb6d0db5fa37e97261e229dbda8e137
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:20:33 2014 +0200
W:543, 4: Dangerous default value DEF_MACROS ({}) as argument (dangerous-default-value)
>---------------------------------------------------------------
backend/backend/mockremote.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index 06441de..d36da87 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -544,11 +544,13 @@ class MockRemote(object):
destdir=DEF_DESTDIR, chroot=DEF_CHROOT, cont=False,
recurse=False, repos=None, callback=None,
remote_basedir=DEF_REMOTE_BASEDIR, remote_tempdir=None,
- macros=DEF_MACROS, lock=None,
+ macros=None, lock=None,
buildroot_pkgs=DEF_BUILDROOT_PKGS):
if repos is None:
repos = DEF_REPOS
+ if macros is None:
+ macros = DEF_MACROS
self.destdir = destdir
self.chroot = chroot
self.repos = repos
9 years, 11 months
[copr] master: W:543, 4: Dangerous default value DEF_REPOS ([]) as argument (dangerous-default-value) (14e2e84)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 14e2e84f9b326a5f4a4b9c27bb28be57a8a7bc80
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:18:41 2014 +0200
W:543, 4: Dangerous default value DEF_REPOS ([]) as argument (dangerous-default-value)
>---------------------------------------------------------------
backend/backend/mockremote.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index d58044e..06441de 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -542,11 +542,13 @@ class MockRemote(object):
def __init__(self, builder=None, user=DEF_USER, timeout=DEF_TIMEOUT,
destdir=DEF_DESTDIR, chroot=DEF_CHROOT, cont=False,
- recurse=False, repos=DEF_REPOS, callback=None,
+ recurse=False, repos=None, callback=None,
remote_basedir=DEF_REMOTE_BASEDIR, remote_tempdir=None,
macros=DEF_MACROS, lock=None,
buildroot_pkgs=DEF_BUILDROOT_PKGS):
+ if repos is None:
+ repos = DEF_REPOS
self.destdir = destdir
self.chroot = chroot
self.repos = repos
9 years, 11 months
[copr] master: W:677, 24: Unused variable 'out' (unused-variable) W:677, 20: Unused variable 'rc' (unused-variable) (acff789)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit acff7899e2bc90147af8a45175bf81df19585a0d
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:16:00 2014 +0200
W:677,24: Unused variable 'out' (unused-variable)
W:677,20: Unused variable 'rc' (unused-variable)
>---------------------------------------------------------------
backend/backend/mockremote.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index e99e74d..d58044e 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -674,7 +674,7 @@ class MockRemote(object):
os.path.basename(pkg)))
built_pkgs.append(pkg)
# createrepo with the new pkgs
- rc, out, err = createrepo(chroot_dir, self.lock)
+ _, _, err = createrepo(chroot_dir, self.lock)
if err.strip():
self.callback.error(
"Error making local repo: {0}".format(chroot_dir))
9 years, 11 months
[copr] master: W:297, 12: Unused variable 'hn' (unused-variable) (e4e81a9)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit e4e81a99d17f37c81a4b854b14ae98859dccb6ff
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Mon Jun 9 18:15:20 2014 +0200
W:297,12: Unused variable 'hn' (unused-variable)
>---------------------------------------------------------------
backend/backend/mockremote.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index d1826c5..e99e74d 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -294,7 +294,7 @@ class Builder(object):
self.conn.module_args = str(cmd)
results = self.conn.run()
tempdir = None
- for hn, resdict in results["contacted"].items():
+ for _, resdict in results["contacted"].items():
tempdir = resdict["stdout"]
# if still nothing then we"ve broken
9 years, 11 months