[copr] new: [frontend] use markdown template filter (9ebc78b)

Repository : http://git.fedorahosted.org/cgit/copr.git On branch : new commit 9ebc78b932d51b3c7a9ff77578837ca1fe1d3ca7 Author: Richard Marko <rmarko(a)fedoraproject.org&gt; Date: Mon Jan 27 15:14:30 2014 +0100 [frontend] use markdown template filter Signed-off-by: Richard Marko <rmarko(a)fedoraproject.org&gt; coprs_frontend/coprs/filters.py | 15 +++++++++++++++ coprs_frontend/coprs/models.py | 13 ++----------- .../coprs/templates/coprs/detail/overview.html | 4 ++-- coprs_frontend/coprs/templates/coprs/show.html | 10 +++++----- 4 files changed, 24 insertions(+), 18 deletions(-) diff --git a/coprs_frontend/coprs/filters.py b/coprs_frontend/coprs/filters.py index 36c568a..b37b7e9 100644 --- a/coprs_frontend/coprs/filters.py +++ b/coprs_frontend/coprs/filters.py @@ -1,4 +1,7 @@ import time +import markdown + +from flask import Markup from coprs import app from coprs import helpers @@ -28,3 +31,15 @@ def os_name_short(os_name, os_version): elif os_name == "epel": return "el{0}".format(os_version) return os_name + + +(a)app.template_filter(&quot;markdown&quot;) +def markdown_filter(data): + if not data: + return '' + + md = markdown.Markdown( + safe_mode="replace", + html_replacement_text="--RAW HTML NOT ALLOWED--") + + return Markup(md.convert(data)) diff --git a/coprs_frontend/coprs/models.py b/coprs_frontend/coprs/models.py index 67f7c3f..bbdd47d 100644 --- a/coprs_frontend/coprs/models.py +++ b/coprs_frontend/coprs/models.py @@ -1,5 +1,4 @@ import datetime -import markdown from sqlalchemy.ext.associationproxy import association_proxy from libravatar import libravatar_url @@ -161,19 +160,11 @@ class Copr(db.Model, helpers.Serializer): @property def description_or_not_filled(self): - md = markdown.Markdown( - safe_mode="replace", - html_replacement_text="--RAW HTML NOT ALLOWED--") - - return md.convert(self.description) or "Description not filled in by author. Very likely personal repository for testing purpose, which you should not use." + return self.description or "Description not filled in by author. Very likely personal repository for testing purpose, which you should not use." @property def instructions_or_not_filled(self): - md = markdown.Markdown( - safe_mode="replace", - html_replacement_text="--RAW HTML NOT ALLOWED--") - - return md.convert(self.instructions) or "Instructions not filled in by author. Author knows what to do. Everybody else should avoid this repo." + return self.instructions or "Instructions not filled in by author. Author knows what to do. Everybody else should avoid this repo." @property def active_chroots(self): diff --git a/coprs_frontend/coprs/templates/coprs/detail/overview.html b/coprs_frontend/coprs/templates/coprs/detail/overview.html index d3bca61..7bebca0 100644 --- a/coprs_frontend/coprs/templates/coprs/detail/overview.html +++ b/coprs_frontend/coprs/templates/coprs/detail/overview.html @@ -6,9 +6,9 @@ {% block detail_body %} <h2>Description</h2> - <div class="shift-right">{{ copr.description_or_not_filled|safe }}</div> + <div class="shift-right">{{ copr.description_or_not_filled|markdown }}</div> <h2>Installation Instructions</h2> - <div class="shift-right">{{ copr.instructions_or_not_filled|safe }}</div> + <div class="shift-right">{{ copr.instructions_or_not_filled|markdown }}</div> <h2>Active Releases</h2> <div class="disclaimer"> The following unofficial repositories are provided as-is by owner of this project. diff --git a/coprs_frontend/coprs/templates/coprs/show.html b/coprs_frontend/coprs/templates/coprs/show.html index 2533171..4a25617 100644 --- a/coprs_frontend/coprs/templates/coprs/show.html +++ b/coprs_frontend/coprs/templates/coprs/show.html @@ -29,12 +29,12 @@ {% for copr in coprs %} <div class="copr"> <a class="coprs-list" href="{{ url_for('coprs_ns.copr_detail', username = copr.owner.name, coprname = copr.name) }}">{{ copr.owner.name }}/{{ copr.name }}</a> - <p>{{ copr.description_or_not_filled|safe }}</p> - <p class="repos"> - {% for mock_chroot in copr.active_chroots %} + <p>{{ copr.description_or_not_filled|markdown }}</p> + <p class="repos"> + {% for mock_chroot in copr.active_chroots %} {{ mock_chroot.os_release|os_name_short(mock_chroot.os_version) }}.{{ mock_chroot.arch }}{% if not loop.last %}, {% endif %} - {% endfor %} - </p> + {% endfor %} + </p> </div> {% else %} <p>No projects...</p>