Hello,
I've the need of using copr-cli in other distros so I've decided to upload it to PyPI. In order to do that I had to change the setup.py file in both copr-cli and copr-python projects.
The problem is that the setup.py was importing the code it was supposed to install and breaking because the dependencies weren't installed yet. To fix that I've added a function that parses the content of the file looking for it's version instead of importing it.
Doing that the installer is able to build the dependencies tree and look for each dependency on the package index.
Also the Alpha classifier used was wrong so I've changed it from:
"Development Status :: 1 - Alpha"
to
"Development Status :: 3 - Alpha"
Last, I've updated the versions to use the tagged versions. You will find my commits attached.
Cheers,
Sergio Oliveira
On 10/19/2015 09:59 PM, Sergio Oliveira wrote:
Hello,
I've the need of using copr-cli in other distros so I've decided to upload it to PyPI. In order to do that I had to change the setup.py file in both copr-cli and copr-python projects.
The problem is that the setup.py was importing the code it was supposed to install and breaking because the dependencies weren't installed yet. To fix that I've added a function that parses the content of the file looking for it's version instead of importing it.
Doing that the installer is able to build the dependencies tree and look for each dependency on the package index.
Also the Alpha classifier used was wrong so I've changed it from:
"Development Status :: 1 - Alpha"to
"Development Status :: 3 - Alpha"Last, I've updated the versions to use the tagged versions. You will find my commits attached.
Thank you for doing that. However for us the relevant version is in the spec file. Is it possible to alter the patch so it reads and parse the version from the spec file?
Mirek
This last patch changes that.
If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.
Cheers,
Sergio Oliveira
On Tue, Oct 20, 2015 at 3:43 AM Miroslav Suchy msuchy@redhat.com wrote:
On 10/19/2015 09:59 PM, Sergio Oliveira wrote:
Hello,
I've the need of using copr-cli in other distros so I've decided to upload it to PyPI. In order to do that I had to change the setup.py file in both copr-cli and copr-python projects.
The problem is that the setup.py was importing the code it was supposed to install and breaking because the dependencies weren't installed yet. To fix that I've added a function that parses the content of the file looking for it's version instead of importing it.
Doing that the installer is able to build the dependencies tree and look for each dependency on the package index.
Also the Alpha classifier used was wrong so I've changed it from:
"Development Status :: 1 - Alpha"to
"Development Status :: 3 - Alpha"Last, I've updated the versions to use the tagged versions. You will find my commits attached.
Thank you for doing that. However for us the relevant version is in the spec file. Is it possible to alter the patch so it reads and parse the version from the spec file?
Mirek
copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel
On 10/22/2015 01:30 PM, Sergio Oliveira wrote:
This last patch changes that.
Hower it does not apply. I have some conflicts :( Can you rebase it?
If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.
*nod*, can you remove it too, please?
Mirek
Ack
On Fri, Oct 23, 2015 at 6:14 AM Miroslav Suchy msuchy@redhat.com wrote:
On 10/22/2015 01:30 PM, Sergio Oliveira wrote:
This last patch changes that.
Hower it does not apply. I have some conflicts :( Can you rebase it?
If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.
*nod*, can you remove it too, please?
Mirek _______________________________________________ copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel
Rebased with master and __version__ removed.
On Fri, Oct 23, 2015 at 8:40 AM Sergio Oliveira seocam@gmail.com wrote:
Ack
On Fri, Oct 23, 2015 at 6:14 AM Miroslav Suchy msuchy@redhat.com wrote:
On 10/22/2015 01:30 PM, Sergio Oliveira wrote:
This last patch changes that.
Hower it does not apply. I have some conflicts :( Can you rebase it?
If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.
*nod*, can you remove it too, please?
Mirek _______________________________________________ copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel
Do you guys need some help for merging? I'm available on #fedora (@seocam) and willing to help.
Cheers,
Sergio
On Mon, Oct 26, 2015 at 10:00 AM Sergio Oliveira seocam@gmail.com wrote:
Rebased with master and __version__ removed.
On Fri, Oct 23, 2015 at 8:40 AM Sergio Oliveira seocam@gmail.com wrote:
Ack
On Fri, Oct 23, 2015 at 6:14 AM Miroslav Suchy msuchy@redhat.com wrote:
On 10/22/2015 01:30 PM, Sergio Oliveira wrote:
This last patch changes that.
Hower it does not apply. I have some conflicts :( Can you rebase it?
If we are going to read versions from spec I would advise to remove the __version__ from the code python files since it won't reflect any real version or useful information.
*nod*, can you remove it too, please?
Mirek _______________________________________________ copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel
Dne 26.10.2015 v 13:00 Sergio Oliveira napsal(a):
Rebased with master and __version__ removed.
Committed as: * 28c7e65 (HEAD -> master, origin/master, origin/HEAD) Removed __version__ from cli and python * 0316256 Added version parse from specs instead of __init__ * b66a538 Fixes to allow copr lib to be installed using setup.py * a496af1 Fixed invalid classifiers * 84d6b40 Fixes to allow copr-cli to be installed using setup.py
Thank you for the contribution.
copr-devel@lists.fedorahosted.org
-
Miroslav Suchý -
Sergio Oliveira