[Crash-catcher] [PATCH] gui: moved the reporter's settings check before the reporter dialog
ABRT shows a warning dialog if user has empty login/password and this dialog is shown after user click "Send" in reporter dialog. This patch moves the check and the warning before reporter dialog right after user selects the reporter plugin. Please review.
J.
On Fri, 2010-03-19 at 16:44 +0100, Jiri Moskovcak wrote:
ABRT shows a warning dialog if user has empty login/password and this dialog is shown after user click "Send" in reporter dialog. This patch moves the check and the warning before reporter dialog right after user selects the reporter plugin. Please review.
diff --git a/src/Gui/CCDBusBackend.py b/src/Gui/CCDBusBackend.py index 414879f..38f22d4 100644 --- a/src/Gui/CCDBusBackend.py +++ b/src/Gui/CCDBusBackend.py @@ -182,11 +182,13 @@ class DBusManager(gobject.GObject): self.job_crash_id = crash_id
def Report(self, report, reporters, reporters_settings = None): - # map < Plguin_name vec <status, message> > + # map < Pluguin_name vec <status, message> >
Still has a typo :)
The rest looks ok to me.
crash-catcher@lists.fedorahosted.org
-
Denys Vlasenko -
Jiri Moskovcak