[ABRT PATCH 4/4] testsuite: enhance koops parser unit tests

Signed-off-by: Jakub Filak jfilak@redhat.com --- Makefile.am | 4 ++- examples/koops-tainted-g | 61 +++++++++++++++++++++++++++++++++++++++++++ examples/koops-tainted-gw | 61 ------------------------------------------- examples/koops-tainted-insane | 6 +++++ examples/koops-tainted-spaces | 8 ++++++ tests/koops-parser.at | 15 ++++++++--- 6 files changed, 89 insertions(+), 66 deletions(-) create mode 100644 examples/koops-tainted-g delete mode 100644 examples/koops-tainted-gw create mode 100644 examples/koops-tainted-insane create mode 100644 examples/koops-tainted-spaces

diff --git a/Makefile.am b/Makefile.am index c628255..a79e520 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,9 @@ DISTCHECK_CONFIGURE_FLAGS = \ --with-systemdsystemunitdir=$$dc_install_base/$(systemdsystemunitdir)

TESTSUITE_FILES = -TESTSUITE_FILES += examples/koops-tainted-gw +TESTSUITE_FILES += examples/koops-tainted-g +TESTSUITE_FILES += examples/koops-tainted-insane +TESTSUITE_FILES += examples/koops-tainted-spaces TESTSUITE_FILES += examples/cut_here.right TESTSUITE_FILES += examples/oops-kernel-3.x.x TESTSUITE_FILES += examples/oops1.right diff --git a/examples/koops-tainted-g b/examples/koops-tainted-g new file mode 100644 index 0000000..f59c740 --- /dev/null +++ b/examples/koops-tainted-g @@ -0,0 +1,61 @@ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564718] ------------[ cut here]------------ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564721] WARNING: atarch/x86/xen/mmu.c:475 xen_make_pte+0x32/0x8e() +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564723] Hardware name: OptiPlex 755 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564725] Modules linked in: nfs +fscache auth_rpcgss nfs_acl tcp_lp ppdev parport_pc lp parport ebtable_nat +ebtables ipt_MASQUERADE iptable_nat nf_nat xt_CHECKSUM iptable_mangle tun +bridge stp llc lockd drbd lru_cache ip6t_REJECT nf_conntrack_ipv6 +nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack +ip6table_filter ip6_tables snd_hda_codec_analog dcdbas snd_hda_intel +snd_hda_codec snd_hwdep snd_seq snd_seq_device 3c59x mii snd_pcm i2c_i801 +serio_raw iTCO_wdt iTCO_vendor_support snd_timer snd soundcore snd_page_alloc +e1000e xen_netback xen_blkback xen_gntdev xen_evtchn sunrpc uinput xenfs +pata_acpi usb_storage ata_generic radeon ttm drm_kms_helper drm i2c_algo_bit +i2c_core [last unloaded: scsi_wait_scan] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564791] Pid: 912, comm: X Tainted: G 3.1.0-0.rc9.git0.0.fc16.x86_64 #1 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564793] Call Trace: +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564797] [<ffffffff81057a56>] warn_slowpath_common+0x83/0x9b +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564800] [<ffffffff81057a88>] warn_slowpath_null+0x1a/0x1c +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564803] [<ffffffff8100527e>] xen_make_pte+0x32/0x8e +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564807] [<ffffffff810045f1>] __raw_callee_save_xen_make_pte+0x11/0x1e +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564810] [<ffffffff81032b0a>] ? pfn_pte+0x26/0x29 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564814] [<ffffffff81032f75>] __change_page_attr_set_clr+0x130/0x749 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564817] [<ffffffff8100782a>] ? get_phys_to_machine+0x1f/0x62 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564821] [<ffffffff81005318>] ? mfn_to_pfn.part.3+0x3e/0x88 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564824] [<ffffffff8100539d>] ? pte_mfn_to_pfn+0x3b/0x4d +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564827] [<ffffffff81005c03>] ? __xen_set_pte+0x1b/0x5b +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564831] [<ffffffff81033543>] __change_page_attr_set_clr+0x6fe/0x749 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564834] [<ffffffff811063e7>] ? __purge_vmap_area_lazy+0x7c/0x17d +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564838] [<ffffffff810336da>] change_page_attr_set_clr+0x14c/0x305 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564842] [<ffffffff81033aa7>] _set_pages_array+0xa3/0xf1 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564845] [<ffffffff81033b08>] set_pages_array_wc+0x13/0x15 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564852] [<ffffffffa0065a2d>] ttm_set_pages_caching+0x39/0x5b [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564858] [<ffffffffa0065b22>] ttm_alloc_new_pages+0xd3/0x15b [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564864] [<ffffffffa0065e09>] ttm_get_pages+0x137/0x361 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564870] [<ffffffffa005fdba>] __ttm_tt_get_page+0x54/0xb0 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564876] [<ffffffffa0060099>] ttm_tt_populate+0x3d/0x7c [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564881] [<ffffffffa006010a>] ttm_tt_bind+0x32/0x66 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564887] [<ffffffffa006178a>] ttm_bo_handle_move_mem+0x114/0x2a1 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564893] [<ffffffffa0061bb6>] ttm_bo_evict+0x29f/0x2e8 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564899] [<ffffffffa0061d51>] ttm_mem_evict_first+0x152/0x180 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564906] [<ffffffffa00623c6>] ttm_bo_mem_space+0x29b/0x2ea [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564912] [<ffffffffa00624cb>] ttm_bo_move_buffer+0xb6/0x10c [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564922] [<ffffffffa001ec90>] ? drm_mm_insert_helper+0xd3/0xec [drm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564928] [<ffffffffa00625d7>] ttm_bo_validate+0xb6/0xf4 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564934] [<ffffffffa0062915>] ttm_bo_init+0x300/0x339 [ttm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564949] [<ffffffffa009a442>] radeon_bo_create+0x1bf/0x248 [radeon] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564965] [<ffffffffa009a194>] ? radeon_bo_clear_surface_reg+0x50/0x50 [radeon] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564983] [<ffffffffa00a9f7a>] radeon_gem_object_create+0x53/0xd8 [radeon] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565001] [<ffffffffa00aa232>] radeon_gem_create_ioctl+0x4b/0x81 [radeon] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565005] [<ffffffff8104402b>] ? should_resched+0xe/0x2d +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565013] [<ffffffffa0015784>] drm_ioctl+0x29e/0x37b [drm] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565031] [<ffffffffa00aa1e7>] ? radeon_gem_pwrite_ioctl+0x28/0x28 [radeon] +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565034] [<ffffffff811de8d4>] ? inode_has_perm+0x32/0x34 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565038] [<ffffffff811de97d>] ? file_has_perm+0xa7/0xc9 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565041] [<ffffffff81136f33>] do_vfs_ioctl+0x452/0x493 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565045] [<ffffffff81136fca>] sys_ioctl+0x56/0x7c +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565048] [<ffffffff811291aa>] ? sys_read+0x61/0x6e +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565059] [<ffffffff814bc0c2>] system_call_fastpath+0x16/0x1b +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565062] ---[ end trace e17fa7b6cce3a141 ]--- + + diff --git a/examples/koops-tainted-gw b/examples/koops-tainted-gw deleted file mode 100644 index 63d8cd9..0000000 --- a/examples/koops-tainted-gw +++ /dev/null @@ -1,61 +0,0 @@ -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564718] ------------[ cut here]------------ -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564721] WARNING: atarch/x86/xen/mmu.c:475 xen_make_pte+0x32/0x8e() -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564723] Hardware name: OptiPlex 755 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564725] Modules linked in: nfs -fscache auth_rpcgss nfs_acl tcp_lp ppdev parport_pc lp parport ebtable_nat -ebtables ipt_MASQUERADE iptable_nat nf_nat xt_CHECKSUM iptable_mangle tun -bridge stp llc lockd drbd lru_cache ip6t_REJECT nf_conntrack_ipv6 -nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack -ip6table_filter ip6_tables snd_hda_codec_analog dcdbas snd_hda_intel -snd_hda_codec snd_hwdep snd_seq snd_seq_device 3c59x mii snd_pcm i2c_i801 -serio_raw iTCO_wdt iTCO_vendor_support snd_timer snd soundcore snd_page_alloc -e1000e xen_netback xen_blkback xen_gntdev xen_evtchn sunrpc uinput xenfs -pata_acpi usb_storage ata_generic radeon ttm drm_kms_helper drm i2c_algo_bit -i2c_core [last unloaded: scsi_wait_scan] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564791] Pid: 912, comm: X Tainted: G W 3.1.0-0.rc9.git0.0.fc16.x86_64 #1 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564793] Call Trace: -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564797] [<ffffffff81057a56>] warn_slowpath_common+0x83/0x9b -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564800] [<ffffffff81057a88>] warn_slowpath_null+0x1a/0x1c -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564803] [<ffffffff8100527e>] xen_make_pte+0x32/0x8e -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564807] [<ffffffff810045f1>] __raw_callee_save_xen_make_pte+0x11/0x1e -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564810] [<ffffffff81032b0a>] ? pfn_pte+0x26/0x29 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564814] [<ffffffff81032f75>] __change_page_attr_set_clr+0x130/0x749 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564817] [<ffffffff8100782a>] ? get_phys_to_machine+0x1f/0x62 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564821] [<ffffffff81005318>] ? mfn_to_pfn.part.3+0x3e/0x88 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564824] [<ffffffff8100539d>] ? pte_mfn_to_pfn+0x3b/0x4d -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564827] [<ffffffff81005c03>] ? __xen_set_pte+0x1b/0x5b -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564831] [<ffffffff81033543>] __change_page_attr_set_clr+0x6fe/0x749 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564834] [<ffffffff811063e7>] ? __purge_vmap_area_lazy+0x7c/0x17d -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564838] [<ffffffff810336da>] change_page_attr_set_clr+0x14c/0x305 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564842] [<ffffffff81033aa7>] _set_pages_array+0xa3/0xf1 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564845] [<ffffffff81033b08>] set_pages_array_wc+0x13/0x15 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564852] [<ffffffffa0065a2d>] ttm_set_pages_caching+0x39/0x5b [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564858] [<ffffffffa0065b22>] ttm_alloc_new_pages+0xd3/0x15b [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564864] [<ffffffffa0065e09>] ttm_get_pages+0x137/0x361 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564870] [<ffffffffa005fdba>] __ttm_tt_get_page+0x54/0xb0 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564876] [<ffffffffa0060099>] ttm_tt_populate+0x3d/0x7c [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564881] [<ffffffffa006010a>] ttm_tt_bind+0x32/0x66 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564887] [<ffffffffa006178a>] ttm_bo_handle_move_mem+0x114/0x2a1 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564893] [<ffffffffa0061bb6>] ttm_bo_evict+0x29f/0x2e8 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564899] [<ffffffffa0061d51>] ttm_mem_evict_first+0x152/0x180 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564906] [<ffffffffa00623c6>] ttm_bo_mem_space+0x29b/0x2ea [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564912] [<ffffffffa00624cb>] ttm_bo_move_buffer+0xb6/0x10c [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564922] [<ffffffffa001ec90>] ? drm_mm_insert_helper+0xd3/0xec [drm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564928] [<ffffffffa00625d7>] ttm_bo_validate+0xb6/0xf4 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564934] [<ffffffffa0062915>] ttm_bo_init+0x300/0x339 [ttm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564949] [<ffffffffa009a442>] radeon_bo_create+0x1bf/0x248 [radeon] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564965] [<ffffffffa009a194>] ? radeon_bo_clear_surface_reg+0x50/0x50 [radeon] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564983] [<ffffffffa00a9f7a>] radeon_gem_object_create+0x53/0xd8 [radeon] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565001] [<ffffffffa00aa232>] radeon_gem_create_ioctl+0x4b/0x81 [radeon] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565005] [<ffffffff8104402b>] ? should_resched+0xe/0x2d -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565013] [<ffffffffa0015784>] drm_ioctl+0x29e/0x37b [drm] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565031] [<ffffffffa00aa1e7>] ? radeon_gem_pwrite_ioctl+0x28/0x28 [radeon] -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565034] [<ffffffff811de8d4>] ? inode_has_perm+0x32/0x34 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565038] [<ffffffff811de97d>] ? file_has_perm+0xa7/0xc9 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565041] [<ffffffff81136f33>] do_vfs_ioctl+0x452/0x493 -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565045] [<ffffffff81136fca>] sys_ioctl+0x56/0x7c -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565048] [<ffffffff811291aa>] ? sys_read+0x61/0x6e -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565059] [<ffffffff814bc0c2>] system_call_fastpath+0x16/0x1b -Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565062] ---[ end trace e17fa7b6cce3a141 ]--- - - diff --git a/examples/koops-tainted-insane b/examples/koops-tainted-insane new file mode 100644 index 0000000..1d3eee6 --- /dev/null +++ b/examples/koops-tainted-insane @@ -0,0 +1,6 @@ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564718] ------------[ cut here]------------ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564721] WARNING: atarch/x86/xen/mmu.c:475 xen_make_pte+0x32/0x8e() +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564791] Pid: 912, comm: X Tainted: ABCDEFGHIJKLMNOPQRSTUVWXYZ 3.1.0-0.rc9.git0.0.fc16.x86_64 #1 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564793] Call Trace: +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564797] [<ffffffff81057a56>] warn_slowpath_common+0x83/0x9b +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565062] ---[ end trace e17fa7b6cce3a141 ]--- diff --git a/examples/koops-tainted-spaces b/examples/koops-tainted-spaces new file mode 100644 index 0000000..8a282d0 --- /dev/null +++ b/examples/koops-tainted-spaces @@ -0,0 +1,8 @@ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564718] ------------[ cut here]------------ +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564721] WARNING: atarch/x86/xen/mmu.c:475 xen_make_pte+0x32/0x8e() +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564791] Pid: 912, comm: X Tainted: 3.1.0-0.rc9.git0.0.fc16.x86_64 #1 +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.564793] Call Trace: +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565059] [<ffffffff814bc0c2>] system_call_fastpath+0x16/0x1b +Oct 11 10:57:36 jerry-opti755 kernel: [ 4552.565062] ---[ end trace e17fa7b6cce3a141 ]--- + + diff --git a/tests/koops-parser.at b/tests/koops-parser.at index 5835100..1004307 100644 --- a/tests/koops-parser.at +++ b/tests/koops-parser.at @@ -35,7 +35,7 @@ int main(void) struct test_struct test[] = { { EXAMPLE_PFX"/cut_here.right", "2.6.32-19.el6.x86_64" }, { EXAMPLE_PFX"/oops-kernel-3.x.x", "3.0.0-3.fc16.i686.PAE" }, - { EXAMPLE_PFX"/koops-tainted-gw", "3.1.0-0.rc9.git0.0.fc16.x86_64"}, + { EXAMPLE_PFX"/koops-tainted-g", "3.1.0-0.rc9.git0.0.fc16.x86_64"}, };

int ret = 0; @@ -77,6 +77,11 @@ int run_test(const struct test_struct *test, int flags) log("%s", test->filename); ret = 1; } + else if (strcmp(tnt, test->expected_results) != 0) + { + log("%s '%s'", test->filename, tnt); + ret = 1; + } };

free(tnt); @@ -88,12 +93,14 @@ int main(void) /* tests run in abrt/tests/testsuite.dir/X, where X is test number */ struct test_struct not_tainted[] = { { EXAMPLE_PFX"/oops1.right", NULL}, + { EXAMPLE_PFX"/koops-tainted-spaces", NULL}, };

struct test_struct tainted[] = { - { EXAMPLE_PFX"/koops-tainted-bg1", "G B " }, - { EXAMPLE_PFX"/oops-same-as-oops4.right", "P " }, - { EXAMPLE_PFX"/koops-tainted-gw", NULL }, + { EXAMPLE_PFX"/koops-tainted-g", "G"}, + { EXAMPLE_PFX"/koops-tainted-bg1", "GB" }, + { EXAMPLE_PFX"/oops-same-as-oops4.right", "P" }, + { EXAMPLE_PFX"/koops-tainted-insane", "ABCDEFGHIJKLMNOPQRSTUVWXYZ" }, };

log("test not tainted");