Signed-off-by: Nikola Pajkovsky npajkovs@redhat.com --- configure.ac | 4 ++-- src/cli/report.cpp | 8 ++++---- src/daemon/Daemon.cpp | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/configure.ac b/configure.ac index 8af0906..4866063 100644 --- a/configure.ac +++ b/configure.ac @@ -15,9 +15,9 @@ AC_PROG_CXX
AC_SYS_LARGEFILE CXXFLAGS="$CXXFLAGS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE \ - -D_FILE_OFFSET_BITS=64 -fno-strict-aliasing " + -D_FILE_OFFSET_BITS=64 -fno-strict-aliasing -std=gnu++98 -Wall -Werror" CFLAGS="$CFLAGS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE \ - -D_FILE_OFFSET_BITS=64 -fno-strict-aliasing -std=gnu99 -Wall" + -D_FILE_OFFSET_BITS=64 -fno-strict-aliasing -std=gnu99 -Wall -Werror"
dnl ****** INTERNATIONALIZATION ********************** GETTEXT_PACKAGE=abrt diff --git a/src/cli/report.cpp b/src/cli/report.cpp index 178a602..84831ff 100644 --- a/src/cli/report.cpp +++ b/src/cli/report.cpp @@ -382,7 +382,7 @@ static int run_report_editor(map_crash_data_t &cr) }
fseek(fp, 0, SEEK_END); - long size = ftell(fp); + size_t size = ftell(fp); fseek(fp, 0, SEEK_SET);
char *text = (char*)xmalloc(size + 1); @@ -610,9 +610,9 @@ static void get_reporter_plugin_settings(const vector_string_t& reporters, map_string_t single_plugin_settings; std::string path = std::string(homedir) + "/.abrt/" + it->first + "."PLUGINS_CONF_EXTENSION; - /* Load plugin config in the home dir. Do not skip lines with empty value (but containing a "key="), - because user may want to override password from /etc/abrt/plugins/*.conf, but he prefers to - enter it every time he reports. */ + // Load plugin config in the home dir. Do not skip lines with empty value (but containing a "key="), + // because user may want to override password from /etc/abrt/plugins/*.conf, but he prefers to + // enter it every time he reports. bool success = LoadPluginSettings(path.c_str(), single_plugin_settings, false); if (!success) continue; diff --git a/src/daemon/Daemon.cpp b/src/daemon/Daemon.cpp index b25be6f..e492114 100644 --- a/src/daemon/Daemon.cpp +++ b/src/daemon/Daemon.cpp @@ -535,8 +535,8 @@ static gboolean handle_inotify_cb(GIOChannel *gio, GIOCondition condition, gpoin /* NB: this variable _must_ be int-sized, ioctl expects that! */ int inotify_bytes = INOTIFY_BUF_SIZE; if (ioctl(g_io_channel_unix_get_fd(gio), FIONREAD, &inotify_bytes) != 0 - || inotify_bytes < sizeof(struct inotify_event) - || inotify_bytes > INOTIFY_BUF_SIZE + || inotify_bytes < (int)sizeof(struct inotify_event) + || inotify_bytes > (int)INOTIFY_BUF_SIZE ) { inotify_bytes = INOTIFY_BUF_SIZE; } @@ -646,7 +646,7 @@ static gboolean handle_inotify_cb(GIOChannel *gio, GIOCondition condition, gpoin delete_debug_dump_dir(fullname); }
- const char *analyzer = get_crash_data_item_content(crashinfo, FILENAME_ANALYZER).c_str(); + //const char *analyzer = get_crash_data_item_content(crashinfo, FILENAME_ANALYZER).c_str(); const char *uid_str = get_crash_data_item_content(crashinfo, CD_UID).c_str();
/* Send dbus signal */
crash-catcher@lists.fedorahosted.org