11:57 a.m.
----- "Gavin Romig-Koch" <gavin(a)redhat.com> wrote:
This patch adds an Action plugin that creates an sosreport and
copies
it
into the Debug Dump directory. Please consider adding it to abrt.
Please tell me if I should create a bugzilla for this patch, or make
alterations to the patch, or if I can answer questions about the
patch.
Few nitpicking at the beginning:
0)
When applying the patch to git I can see lines like
Stripping trailing CRs from patch.
looks like the patch's lines ends with <cr><lf> pair instead of
<lf>.
Dunno where the problem emerged (MUA, server, ?).
1)
abrt.spec: Require "sos" in plugin-sosreportaction sub-package.
2)
Simple man page is missing.
3)
abrt.spec: libsosreportaction.so is likely wrong, should be
SOSreportAction.so?
4)
RedHat inc. -> Red Hat Inc.
But this should be fixed in the rest of source files also.
Compiled and installed the plugin, enabled in /etc/abrt/abrt.conf
(not necessary I guess) crashed few apps but can't find the
tarball anywhere. Even after generating the bug report via
abrt-guit. Where is it locate? Is it /var/cache/abrt/<uuid.pid>/?
I can only say that from abrt daemon output it seems that
the plugin was loaded.
Another point:
For me, it takes quite a bit of time to gather all the data
sosreport needs (tried the command from sources):
real 6m11.265s
user 4m23.643s
sys 0m19.888s
How does it perform when executed from abrt? Does it stop
abrt for several minutes until it gathers all the data, or
it runs in background?
-gavin...
Michal
1:35 p.m.
New subject: [Crash-catcher] PATCH: SOSreportAction
On 06/25/2009 12:57 PM, Michal Nowak wrote:
0)
When applying the patch to git I can see lines like
Stripping trailing CRs from patch.
looks like the patch's lines ends with<cr><lf> pair instead
of<lf>.
Dunno where the problem emerged (MUA, server, ?).
Don't know. Used the copy of the patch I got back from the mailing
list, a fresh checkout of abrt, and "patch -p1 <sosreport-plugin.patch",
works without any messages.
1)
abrt.spec: Require "sos" in plugin-sosreportaction sub-package.
yes.
2)
Simple man page is missing.
yes.
3)
abrt.spec: libsosreportaction.so is likely wrong, should be
SOSreportAction.so?
very much yes.
4)
RedHat inc. -> Red Hat Inc.
yes.
Compiled and installed the plugin, enabled in /etc/abrt/abrt.conf
(not necessary I guess) crashed few apps but can't find the
tarball anywhere. Even after generating the bug report via
abrt-guit. Where is it locate? Is it /var/cache/abrt/<uuid.pid>/?
I can only say that from abrt daemon output it seems that
the plugin was loaded.
You need to do more than enable it, you need to say that you want it to
run at crash time. Add this line to abrt.conf:
ActionsAndReporters = SOSreportAction()
I think you could also use it to specify that you want it run only when,
say, bind crashed:
[ AnalyzerActionsAndReporters ]
CCpp:bind = SOSreportAction()
But I haven't tested this, and am not sure I'm correct about this.
Another point:
For me, it takes quite a bit of time to gather all the data
sosreport needs (tried the command from sources):
real 6m11.265s
user 4m23.643s
sys 0m19.888s
How does it perform when executed from abrt? Does it stop
abrt for several minutes until it gathers all the data, or
it runs in background?
The plugin itself does wait for sosreport to complete, but I don't know
if abrt stops for each plugin, or if it runs the plugins in the
background - I haven't looked.
The most time consuming part of sosreport is running "rpm -Va". For the
initial cut of this plugin I wrote it to run a fixed set of sosreport
arguments (which specifically turns off generation of the rpm -Va
report, that's the "rpm.rpmva=off" stuff in the patch). Once the basic
outline of the plugin is accepted, my plan was to add stuff like the
ability to specify the arguments to sosreport in the abrt.conf file.
-gavin...
5441
days inactive
5441
days old
crash-catcher@lists.fedorahosted.org
1 comments
2 participants
participants (2)
-
Gavin Romig-Koch -
Michal Nowak