Impressive and it works as expected even in KDE.
Push it!
On Tuesday 06 of November 2012 16:40:12 Jiri Moskovcak wrote:
---
src/gui-wizard-gtk/wizard.c | 13 +++++++++++++
src/gui-wizard-gtk/wizard.glade | 40
++++++++++++++++++++++++++++++---------- 2 files changed, 43 insertions(+),
10 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 20ae45e..6ec3c04 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -99,6 +99,8 @@ static gboolean g_warning_issued;
static GtkEventBox *g_ev_search_up;
static GtkEventBox *g_ev_search_down;
static GtkSpinner *g_spinner_event_log;
+static GtkImage *g_img_process_fail;
+static GtkImage *g_img_process_ok;
static GtkWidget *g_top_most_window;
@@ -1753,6 +1755,11 @@ static gboolean consume_cmd_output(GIOChannel
*source, GIOCondition condition, g
/* Hide spinner and stop btn */
gtk_widget_hide(GTK_WIDGET(g_spinner_event_log));
+ if (retval != 0)
+ gtk_widget_show(GTK_WIDGET(g_img_process_fail));
+ else
+ gtk_widget_show(GTK_WIDGET(g_img_process_ok));
+
gtk_widget_hide(g_btn_stop);
/* Enable (un-gray out) navigation buttons */
gtk_widget_set_sensitive(g_btn_close, true);
@@ -1900,6 +1907,10 @@ static void start_event_run(const char *event_name,
append_to_textview(evd->tv_log, msg);
free(msg);
+ /* don't bother testing if they are visible, this is faster */
+ gtk_widget_hide(GTK_WIDGET(g_img_process_fail));
+ gtk_widget_hide(GTK_WIDGET(g_img_process_ok));
+
gtk_widget_show(GTK_WIDGET(g_spinner_event_log));
gtk_widget_show(g_btn_stop);
/* Disable (gray out) navigation buttons */
@@ -2884,6 +2895,8 @@ static void add_pages(void)
g_ev_search_up = GTK_EVENT_BOX(
gtk_builder_get_object(g_builder, "ev_search_up")); g_ev_search_down
= GTK_EVENT_BOX( gtk_builder_get_object(g_builder, "ev_search_down"));
g_spinner_event_log = GTK_SPINNER(
gtk_builder_get_object(g_builder, "spinner_event_log")); +
g_img_process_ok = GTK_IMAGE( gtk_builder_get_object(g_builder,
"img_process_ok")); + g_img_process_fail = GTK_IMAGE(
gtk_builder_get_object(g_builder, "img_process_fail"));
gtk_widget_set_no_show_all(GTK_WIDGET(g_spinner_event_log), true);
diff --git a/src/gui-wizard-gtk/wizard.glade
b/src/gui-wizard-gtk/wizard.glade index 5632c54..53e215e 100644
--- a/src/gui-wizard-gtk/wizard.glade
+++ b/src/gui-wizard-gtk/wizard.glade
@@ -159,11 +159,9 @@
<child>
<object class="GtkCheckButton" id="cb_no_comment">
<property name="label" translatable="yes">I
don't know what
caused this problem</property> - <property
name="use_action_appearance">False</property> <property
name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">False</property>
- <property
name="use_action_appearance">False</property>
<property name="xalign">0</property>
<property name="draw_indicator">True</property>
</object>
@@ -205,11 +203,9 @@
<child>
<object class="GtkButton" id="button_cfg1">
<property name="label">gtk-preferences</property>
- <property
name="use_action_appearance">False</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">True</property>
- <property
name="use_action_appearance">False</property>
<property name="use_underline">True</property>
<property name="use_stock">True</property>
<property name="image_position">right</property>
@@ -401,7 +397,7 @@
</object>
<packing>
<property name="x_options">GTK_FILL</property>
- <property name="y_options"></property>
+ <property name="y_options"/>
</packing>
</child>
<child>
@@ -445,11 +441,9 @@
<child>
<object class="GtkButton" id="btn_add_file">
<property name="label"
translatable="yes">Attach a
file</property> - <property
name="use_action_appearance">False</property> <property
name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">True</property>
- <property
name="use_action_appearance">False</property>
</object>
<packing>
<property name="expand">False</property>
@@ -470,12 +464,10 @@
<child>
<object class="GtkCheckButton" id="cb_approve_bt">
<property name="label" translatable="yes">I
reviewed the data
and _agree with submitting it</property> - <property
name="use_action_appearance">False</property> <property
name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">False</property>
<property name="tooltip_text"
translatable="yes">If you are
reporting to a remote server, make sure you removed all private data (such
as usernames and passwords). Backtrace, command line, environment variables
are the typical items in need of examining.</property> -
<property name="use_action_appearance">False</property>
<property
name="use_underline">True</property>
<property name="xalign">0</property>
<property name="draw_indicator">True</property>
@@ -515,6 +507,34 @@
</packing>
</child>
<child>
+ <object class="GtkImage" id="img_process_ok">
+ <property name="can_focus">False</property>
+ <property name="no_show_all">True</property>
+ <property name="stock">gtk-apply</property>
+ <property name="icon-size">1</property>
+ </object>
+ <packing>
+ <property name="expand">False</property>
+ <property name="fill">True</property>
+ <property name="padding">5</property>
+ <property name="position">1</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkImage" id="img_process_fail">
+ <property name="can_focus">False</property>
+ <property name="no_show_all">True</property>
+ <property
name="stock">gtk-dialog-error</property>
+ <property name="icon-size">1</property>
+ </object>
+ <packing>
+ <property name="expand">False</property>
+ <property name="fill">True</property>
+ <property name="padding">5</property>
+ <property name="position">2</property>
+ </packing>
+ </child>
+ <child>
<object class="GtkLabel" id="lbl_event_log">
<property name="visible">True</property>
<property name="can_focus">False</property>
@@ -528,7 +548,7 @@
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
- <property name="position">1</property>
+ <property name="position">3</property>
</packing>
</child>
</object>