Please, split it into two separate patches and please comment the decision to
set default minimum rating to 0.
On Wednesday 07 of November 2012 13:53:11 Jiri Moskovcak wrote:
---
src/gui-wizard-gtk/wizard.c | 6 +++++-
src/lib/event_config.c | 1 -
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c
index 6ec3c04..9a211e3 100644
--- a/src/gui-wizard-gtk/wizard.c
+++ b/src/gui-wizard-gtk/wizard.c
@@ -2293,7 +2293,7 @@ static char *get_next_processed_event(GList
**events_list) *events_list = g_list_concat(expanded_list, *events_list);
else
{
- VERB2 log("No event was expanded, will continue continue with
the next one."); + VERB2 log("No event was expanded, will
continue with the next one."); /* no expanded event try the next event */
return get_next_processed_event(events_list);
}
@@ -2412,6 +2412,10 @@ static char *setup_next_processed_event(GList
**events_list) {
/* No next event, go to progress page and finish */
gtk_label_set_text(g_lbl_event_log, _("Processing finished."));
+ /* we don't know the result of the previous event here
+ * so at least hide the spinner, because we're obviously finished
+ */
+ gtk_widget_hide(GTK_WIDGET(g_spinner_event_log));
update_gui_on_finished_reporting();
return NULL;
}
diff --git a/src/lib/event_config.c b/src/lib/event_config.c
index fda79bc..e766470 100644
--- a/src/lib/event_config.c
+++ b/src/lib/event_config.c
@@ -29,7 +29,6 @@ event_option_t *new_event_option(void)
event_config_t *new_event_config(void)
{
event_config_t *e = xzalloc(sizeof(event_config_t));
- e->ec_minimal_rating = 3;
return e;
}