5:05 a.m.
Closes #107
---
configure.ac | 1 +
src/applet/applet.c | 8 +++++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 436cfcd..1e32ffe 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,6 +141,7 @@ PKG_CHECK_MODULES([POLKIT], [polkit-gobject-1])
PKG_CHECK_MODULES([GIO], [gio-2.0])
PKG_CHECK_MODULES([SATYR], [satyr])
PKG_CHECK_MODULES([SYSTEMD_JOURNAL], [libsystemd-journal])
+PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS], [gsettings-desktop-schemas >= 3.15.1])
PKG_PROG_PKG_CONFIG
AC_ARG_WITH([systemdsystemunitdir],
diff --git a/src/applet/applet.c b/src/applet/applet.c
index e5ac02a..1aa8cfe 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -83,7 +83,13 @@ static bool get_configured_bool_or_default(const char *opt_name, bool
def)
static bool is_autoreporting_enabled(void)
{
- return get_configured_bool_or_default("AutoreportingEnabled",
g_settings_autoreporting);
+ GSettings *settings;
+ gboolean ret;
+
+ settings = g_settings_new ("org.gnome.desktop.privacy");
+ ret = g_settings_get_boolean (settings, "report-technical-problems");
+ g_object_unref (settings);
+ return ret;
}
static bool is_ureport_auth_enabled(void)
--
2.1.0
6:41 a.m.
Thank you for the patch!
Is there any possibility to detect whether the gsetting has the default value
in order to be able to fallback to the ABRT configuration files?
I don't want to ditch the current configuration :(
Regards,
Jakub
On Wednesday 14 of January 2015 12:05:59 Bastien Nocera wrote:
Closes #107
---
configure.ac | 1 +
src/applet/applet.c | 8 +++++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 436cfcd..1e32ffe 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,6 +141,7 @@ PKG_CHECK_MODULES([POLKIT], [polkit-gobject-1])
PKG_CHECK_MODULES([GIO], [gio-2.0])
PKG_CHECK_MODULES([SATYR], [satyr])
PKG_CHECK_MODULES([SYSTEMD_JOURNAL], [libsystemd-journal])
+PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS], [gsettings-desktop-schemas
>= 3.15.1])
PKG_PROG_PKG_CONFIG
AC_ARG_WITH([systemdsystemunitdir],
diff --git a/src/applet/applet.c b/src/applet/applet.c
index e5ac02a..1aa8cfe 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -83,7 +83,13 @@ static bool get_configured_bool_or_default(const char
*opt_name, bool def)
static bool is_autoreporting_enabled(void)
{
- return get_configured_bool_or_default("AutoreportingEnabled",
g_settings_autoreporting); + GSettings *settings;
+ gboolean ret;
+
+ settings = g_settings_new ("org.gnome.desktop.privacy");
+ ret = g_settings_get_boolean (settings, "report-technical-problems");
+ g_object_unref (settings);
+ return ret;
}
static bool is_ureport_auth_enabled(void)
6:43 a.m.
On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote:
Thank you for the patch!
Is there any possibility to detect whether the gsetting has the default value
in order to be able to fallback to the ABRT configuration files?
Why? You expect the Privacy settings in GNOME to read the abrt config
file?
I don't want to ditch the current configuration :(
Why not? I don't understand what you would gain by doing that. Avoiding
a single click?
6:54 a.m.
On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote:
On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote:
> Thank you for the patch!
>
> Is there any possibility to detect whether the gsetting has the default
> value in order to be able to fallback to the ABRT configuration files?
Why? You expect the Privacy settings in GNOME to read the abrt config
file?
No, but I have some concerns about KDE and other Desktop Environments.
> I don't want to ditch the current configuration :(
Why not? I don't understand what you would gain by doing that. Avoiding
a single click?
No, for the same reason as above.
Jakub
7:22 a.m.
On Wed, 2015-01-14 at 13:54 +0100, Jakub Filak wrote:
On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote:
> On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote:
> > Thank you for the patch!
> >
> > Is there any possibility to detect whether the gsetting has the default
> > value in order to be able to fallback to the ABRT configuration files?
>
> Why? You expect the Privacy settings in GNOME to read the abrt config
> file?
>
No, but I have some concerns about KDE and other Desktop Environments.
KDE and other desktops can use that same GSettings. I'm pretty sure that
glib is already dragged in the KDE spin for example.
> > I don't want to ditch the current configuration :(
>
> Why not? I don't understand what you would gain by doing that. Avoiding
> a single click?
No, for the same reason as above.
9:13 a.m.
On Wednesday 14 of January 2015 14:22:50 Bastien Nocera wrote:
On Wed, 2015-01-14 at 13:54 +0100, Jakub Filak wrote:
> On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote:
> > On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote:
> > > Thank you for the patch!
> > >
> > > Is there any possibility to detect whether the gsetting has the
> > > default
> > > value in order to be able to fallback to the ABRT configuration files?
> >
> > Why? You expect the Privacy settings in GNOME to read the abrt config
> > file?
>
> No, but I have some concerns about KDE and other Desktop Environments.
KDE and other desktops can use that same GSettings. I'm pretty sure that
glib is already dragged in the KDE spin for example.
I am not concerned about the depencies. ABRT/libreport are based on GLib :)
I am wondering how are they supposed to turn auto-reporting on/off?
Jakub
9:14 a.m.
On Wed, 2015-01-14 at 16:13 +0100, Jakub Filak wrote:
On Wednesday 14 of January 2015 14:22:50 Bastien Nocera wrote:
> On Wed, 2015-01-14 at 13:54 +0100, Jakub Filak wrote:
> > On Wednesday 14 of January 2015 13:43:59 Bastien Nocera wrote:
> > > On Wed, 2015-01-14 at 13:41 +0100, Jakub Filak wrote:
> > > > Thank you for the patch!
> > > >
> > > > Is there any possibility to detect whether the gsetting has the
> > > > default
> > > > value in order to be able to fallback to the ABRT configuration
files?
> > >
> > > Why? You expect the Privacy settings in GNOME to read the abrt config
> > > file?
> >
> > No, but I have some concerns about KDE and other Desktop Environments.
>
> KDE and other desktops can use that same GSettings. I'm pretty sure that
> glib is already dragged in the KDE spin for example.
I am not concerned about the depencies. ABRT/libreport are based on GLib :)
I am wondering how are they supposed to turn auto-reporting on/off?
They'd write a settings panel that toggles it. Or call:
gsettings set org.gnome.desktop.privacy report-technical-problems true
10 a.m.
On Wed, 2015-01-14 at 16:50 +0100, Jakub Filak wrote:
> +PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS],
[gsettings-desktop-schemas
> >= 3.15.1])
I am sorry but where can I get gsettings-desktop-schemas >= 3.15.1?
In git master of gsettings-desktop-schemas:
https://git.gnome.org/browse/gsettings-desktop-schemas/
Cheers
8:17 a.m.
On Wed, 2015-01-14 at 17:00 +0100, Bastien Nocera wrote:
On Wed, 2015-01-14 at 16:50 +0100, Jakub Filak wrote:
> > +PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS], [gsettings-desktop-schemas
> > >= 3.15.1])
>
> I am sorry but where can I get gsettings-desktop-schemas >= 3.15.1?
In git master of gsettings-desktop-schemas:
https://git.gnome.org/browse/gsettings-desktop-schemas/
It's now in gsettings-desktop-schemas 3.15.4:
https://download.gnome.org/sources/gsettings-desktop-schemas/3.15/
9:35 a.m.
On Monday 19 of January 2015 15:17:09 Bastien Nocera wrote:
On Wed, 2015-01-14 at 17:00 +0100, Bastien Nocera wrote:
> On Wed, 2015-01-14 at 16:50 +0100, Jakub Filak wrote:
> > > +PKG_CHECK_MODULES([GSETTINGS_DESKTOP_SCHEMAS],
> > > [gsettings-desktop-schemas
> > >
> > > >= 3.15.1])
> >
> > I am sorry but where can I get gsettings-desktop-schemas >= 3.15.1?
>
> In git master of gsettings-desktop-schemas:
> https://git.gnome.org/browse/gsettings-desktop-schemas/
It's now in gsettings-desktop-schemas 3.15.4:
https://download.gnome.org/sources/gsettings-desktop-schemas/3.15/
I've opened this pull request:
https://github.com/abrt/abrt/pull/903
Let's move the discussion there.
Thanks!
Jakub
3404
days inactive
3411
days old
crash-catcher@lists.fedorahosted.org
11 comments
2 participants
participants (2)
-
Bastien Nocera -
Jakub Filak