Re: Suspected reference leaks in gdb (was Re: python exceptions from refcount checker)
On Mon, 2011-10-17 at 13:32 -0600, Tom Tromey wrote:
>>>>> "David" == David Malcolm
<dmalcolm(a)redhat.com> writes:
David> I'm attaching some HTML error reports.
David> Within gdb/python/py-breakpoint.c: gdbpy_breakpoints
David> there appear to be some false positives about returning NULL without
David> setting an exception
Yeah. On that path the error will have been set by 'build_bp_list'.
David>, but the "ob_refcnt of '*list' is 1 too high"
David> errors appear to be a genuine memory leak in gdb.breakpoints()
I agree.
Thanks; filed as:
http://sourceware.org/bugzilla/show_bug.cgi?id=13308
(I hand-edited the HTML before reporting, to remove the false positives;
thankfully the HTML is relatively sane).
David> Within gdb/python/py-inferior.c : gdbpy_inferiors
David> this seems very similar to the above, both with analogous false
David> positives, and with what appear to be genuine leaks of "*list".
Yup.
Filed as:
http://sourceware.org/bugzilla/show_bug.cgi?id=13309
David> There are a few more of these; I'm trying to decide
what the best place
David> to send them to is, given that there's a fair chance that the checker
David> has errors within it.
I guess gdb bug reports, if that isn't too much trouble.
http://sourceware.org/bugzilla/
Thanks. I've filed another one as:
http://sourceware.org/bugzilla/show_bug.cgi?id=13310
Alternatively if most of the noise is gone from the plugin output,
one
of us can run the plugin and work through the gdb bugs.
Unfortunately there's
still a lot of noise in the output, which I'm
slowly fixing...
Dave