Re: [Fedora-haskell-list] Packaging guidelines and macros update
by Jens-Ulrik Petersen
----- "Bryan O'Sullivan" <bos(a)serpentine.com> wrote:
> I've got an outline of the new documentation process here:
:
> I also did a drive-by update of some other parts of that page, but
> it's somewhat out of date compared to the hacking that Jens and I
> have been doing lately.
Thanks Bryan. I finally got round to editing and revising the guidelines:
https://fedoraproject.org/wiki/PackagingDrafts/Haskell
and I am finally reasonably happy with them.
Perhaps we can leave them a week or two for the rest of the SIG to hopefully scrutinise them and then submit the revision to FPC for review and approval of the revision. Now that ghc-zlib has been approved it should hopefully be easier this time.
As you probably noticed by now I have moved the .spec templates directly into the ghc package and provided a primitive shell script called cabal2spec to generate .spec files out of Cabal hackages: when there are no dependencies they should build basically without change and be compliant with the guidelines: so that makes it trivial now to create new cabal rpm packages. Obviously in the long run we should rewrite the script in Haskell (I was being lazy and have written more shell script recently than Haskell :-(), or use cabal-rpm if it can be made compliant to the guidelines for Fedora (I sent submitted a first patch for that long along now while we were discussing the original guidelines...).
ghc-6.10.1-5.fc11 is the latest build, has the script and templates and works fine on F10 (and F9 I expect). Once we sort out gtk2hs-docs for F10 we could update F10 to 6.10.1 I think. We can also backport the templates and script to ghc-6.8.3 if it is worth doing.
Jens
15 years, 5 months
[Fedora-haskell-list] [Bug 425882] Review Request: ghc-zlib - zlib bindings for ghc
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=425882
--- Comment #45 from Jens Petersen <petersen(a)redhat.com> 2008-11-25 01:27:25 EDT ---
(In reply to comment #44)
> Honestly I would suggest that any templates or automated tools not have %files lists with
> duplicated files so that less experienced packagers don't get the impression
> that it is necessary to duplicate the license file or acceptable in general to
> have duplicate entries in %files lists.
Right - I will remove it.
> I believe that with the patch in comment 42, this package is fine, and I'm
> happy to see this through.
Thanks for reviewing the first new haskell library package. :-)
> I guess we need another guideline update to handle the changed scriptlets, though.
Yep. Planning to rework the text, then rfc, and submit to FPC again for
review. :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 5 months
[Fedora-haskell-list] [Bug 425882] Review Request: ghc-zlib - zlib bindings for ghc
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=425882
Jason Tibbitts <tibbs(a)math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #44 from Jason Tibbitts <tibbs(a)math.uh.edu> 2008-11-24 23:37:01 EDT ---
The opinion from the legal folks is that even if a srpm creates subpackages
that are not related in name or dependency chain, it is still only necessary to
include the license file in one of them. It's been discussed, however, and
it's also not a blocker if that's really what you want to do. Honestly I would
suggest that any templates or automated tools not have %files lists with
duplicated files so that less experienced packagers don't get the impression
that it is necessary to duplicate the license file or acceptable in general to
have duplicate entries in %files lists.
I believe that with the patch in comment 42, this package is fine, and I'm
happy to see this through.
APPROVED
I guess we need another guideline update to handle the changed scriptlets,
though.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 5 months
[Fedora-haskell-list] guidelines install scripts
by Jens-Ulrik Petersen
Hi,
So I have been thinking a bit more about the install scripts in the guidelines, since there seems to me to be no good reason to run ghc-pkg and gen_contents_index more than once per rpm transaction. (Perhaps we should even recommend subpackaging ghc packages.)
But I thought I would just ask here once before committing and building the change below to make sure I am not missing something:
--- ghc-rpm-macros.ghc 23 Oct 2008 08:31:20 -0000 1.8
+++ ghc-rpm-macros.ghc 24 Nov 2008 07:30:44 -0000
@@ -40,7 +40,6 @@
%{nil}
%ghc_preinst_script \
-[ "$1" = 2 ] && %{pkg_libdir}/unregister.sh >&/dev/null || : \
%{nil}
%ghc_postinst_script \
@@ -48,11 +47,10 @@
%{nil}
%ghc_preun_script \
-%{pkg_libdir}/unregister.sh >&/dev/null \
+[ "$1" = 0 ] && %{pkg_libdir}/unregister.sh >&/dev/null \
%{nil}
%ghc_postun_script \
-[ "$1" = 1 ] && %{pkg_libdir}/register.sh >& /dev/null || : \
%{nil}
%ghc_reindex_haddock \
Summarizing: %ghc_preinst_script and %ghc_postun_script should not been needed since ghc_postinst_script runs "ghc-pkg update".
And %ghc_reindex_haddock only needs to be run in %post not %postun.
Jens
ps We probably also need to think a bit of how to handle indexing with different haddock versions: gtk2hs.darcs requires haddock-2.4 to build docs, so we can't index with it unless we rebuild ghc with haddock-2.4 - we could just skip %ghc_reindex_haddock for gtk2hs for now though, but probably need to ressurrect haddock in rawhide for gtk2hs docs.
15 years, 5 months