Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ghc-data-default - A class for types with a default value
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Summary: Review Request: ghc-data-default - A class for types with a default value Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lakshminaras2002@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-haskell-list@redhat.com, package-review@lists.fedoraproject.org Blocks: 648247 Classification: Fedora Story Points: --- Type: ---
Spec file : http://narasim.fedorapeople.org/package_reviews/ghc-data-default.spec
SRPM file : http://narasim.fedorapeople.org/package_reviews/ghc-data-default-0.3.0-1.fc1...
New dependency on ghc-dlist.
rpmlint output: rpmlint -i ghc-data-default-0.3.0-1.fc14.i686.rpm ghc-data-default-0.3.0-1.fc14.src.rpm ghc-data-default-devel-0.3.0-1.fc14.i686.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mathstuf@gmail.com
--- Comment #1 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-09-10 01:39:40 EDT --- *** Bug 648246 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-data-default
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shakthimaan@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |Ready
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |petersen@redhat.com Flag| |fedora-review?
--- Comment #2 from Jens Petersen petersen@redhat.com 2011-09-27 06:10:26 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3380247
Looks fine to me. Will post a review soon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Jens Petersen petersen@redhat.com 2011-09-28 06:57:51 EDT --- Here is the review:
+:ok, NA: not applicable
MUST Items: [+] MUST: rpmlint output
clean
[+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release
2084fb7d26df07eb6b278c5a8ea04d32 data-default-0.3.0.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch [NA] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items: [+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #4 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-09-28 10:12:06 EDT --- Thanks!
New Package SCM Request ======================= Package Name: ghc-data-default Short Description: A class for types with a default value Owners: narasim Branches: f14 f15 f16 InitialCC: haskell-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|Ready |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-09-29 08:11:54 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-09-30 00:05:56 EDT --- ghc-data-default-0.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-09-30 00:06:04 EDT --- ghc-data-default-0.3.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-09-30 00:06:12 EDT --- ghc-data-default-0.3.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-09-30 14:44:53 EDT --- ghc-data-default-0.3.0-1.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ghc-data-default-0.3.0-1.fc | |15 Resolution| |ERRATA Last Closed| |2011-10-09 02:54:13
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-10-09 02:54:13 EDT --- ghc-data-default-0.3.0-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-data-default-0.3.0-1.fc |ghc-data-default-0.3.0-1.fc |15 |14
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-10-09 02:58:31 EDT --- ghc-data-default-0.3.0-1.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-data-default-0.3.0-1.fc |ghc-data-default-0.3.0-1.fc |14 |16
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-10-09 15:39:51 EDT --- ghc-data-default-0.3.0-1.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Lakshmi Narasimhan lakshminaras2002@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |746557
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #13 from Jens Petersen petersen@redhat.com --- Package Change Request ====================== Package Name: ghc-data-default New Branches: el6 epel7 Owners: petersen InitialCC: haskell-sig
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=737228
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- ghc-data-default-0.5.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-data-default-0.5.1-2.el6
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-data-default-0.3.0-1.fc |ghc-data-default-0.5.1-2.el |16 |6
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- ghc-data-default-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=737228
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|ghc-data-default |
haskell-devel@lists.fedoraproject.org