----- Original Message -----
From: "Rob Crittenden" <rcritten(a)redhat.com>
To: "Ipsilon" <ipsilon(a)lists.fedorahosted.org>
Sent: Tuesday, May 5, 2015 2:13:48 PM
Subject: Patches pending review
Here is a list of the patches I have pending review:
ticket 35:
https://fedorapeople.org/cgit/rcritten/public_git/ipsilon.git/.git/commit...
This one looks good but seem to need a rebase, cherry-pick barfs.
I've had no time to look at this one yet.
This is reaaaallly ugly, can we rather have a config option we look for and not enable
sssd
if this optoin is not set ?
This way you *can* enable/disable it via the admin UI, which is handy if you are testing
stuff as an admin, you just shouldn't be able to change the configuration. (mark the
module
cnfiguration with a "read-only" property somewhere ?
I think we shouldn't really allow non-mutual auth, if that check is because
mod_auth_gssapi
fails to reutn the token on a 200 OK, then we just need to require a new enough
mod_auth_gssapi, Ifixed that bug in master a couple of weeks ago, and can make a release
if necessary.
Otherwise it looks good, but haven't yet tested it.
ACK and pushed this one to master.
HTH,
Simo.
--
Simo Sorce * Red Hat, Inc. * New York