[OS-BUILD PATCHv2] [redhat] Update scripts to put new configs under
ark-common
by Patrick Talbert (via Email Bridge)
From: Patrick Talbert <ptalbert(a)redhat.com>
[redhat] Update scripts to put new configs under ark-common
The current automated workflow creates new kernel config items in a
pending-common/generic directory and produces an MR which proposes
moving them to common/generic.
These are config settings for ARK so really we should use a pending-ark
directory and propose moving them to the ark/generic directory.
Update the relevant scripts and documentation to take care of this.
Signed-off-by: Patrick Talbert <ptalbert(a)redhat.com>
diff --git a/redhat/configs/pending-common/debug/arm/aarch64/README b/redhat/configs/pending-ark/debug/arm/aarch64/README
rename from redhat/configs/pending-common/debug/arm/aarch64/README
rename to redhat/configs/pending-ark/debug/arm/aarch64/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/debug/arm/aarch64/README
+++ b/redhat/configs/pending-ark/debug/arm/aarch64/README
diff --git a/redhat/configs/pending-common/debug/powerpc/README b/redhat/configs/pending-ark/debug/powerpc/README
rename from redhat/configs/pending-common/debug/powerpc/README
rename to redhat/configs/pending-ark/debug/powerpc/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/debug/powerpc/README
+++ b/redhat/configs/pending-ark/debug/powerpc/README
diff --git a/redhat/configs/pending-common/debug/s390x/README b/redhat/configs/pending-ark/debug/s390x/README
rename from redhat/configs/pending-common/debug/s390x/README
rename to redhat/configs/pending-ark/debug/s390x/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/debug/s390x/README
+++ b/redhat/configs/pending-ark/debug/s390x/README
diff --git a/redhat/configs/pending-common/debug/x86/x86_64/README b/redhat/configs/pending-ark/debug/x86/x86_64/README
rename from redhat/configs/pending-common/debug/x86/x86_64/README
rename to redhat/configs/pending-ark/debug/x86/x86_64/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/debug/x86/x86_64/README
+++ b/redhat/configs/pending-ark/debug/x86/x86_64/README
diff --git a/redhat/configs/pending-common/generic/arm/aarch64/README b/redhat/configs/pending-ark/generic/arm/aarch64/README
rename from redhat/configs/pending-common/generic/arm/aarch64/README
rename to redhat/configs/pending-ark/generic/arm/aarch64/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/generic/arm/aarch64/README
+++ b/redhat/configs/pending-ark/generic/arm/aarch64/README
diff --git a/redhat/configs/pending-common/generic/powerpc/README b/redhat/configs/pending-ark/generic/powerpc/README
rename from redhat/configs/pending-common/generic/powerpc/README
rename to redhat/configs/pending-ark/generic/powerpc/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/generic/powerpc/README
+++ b/redhat/configs/pending-ark/generic/powerpc/README
diff --git a/redhat/configs/pending-common/generic/s390x/README b/redhat/configs/pending-ark/generic/s390x/README
rename from redhat/configs/pending-common/generic/s390x/README
rename to redhat/configs/pending-ark/generic/s390x/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/generic/s390x/README
+++ b/redhat/configs/pending-ark/generic/s390x/README
diff --git a/redhat/configs/pending-common/generic/x86/x86_64/README b/redhat/configs/pending-ark/generic/x86/x86_64/README
rename from redhat/configs/pending-common/generic/x86/x86_64/README
rename to redhat/configs/pending-ark/generic/x86/x86_64/README
index blahblah..blahblah 100644
--- a/redhat/configs/pending-common/generic/x86/x86_64/README
+++ b/redhat/configs/pending-ark/generic/x86/x86_64/README
diff --git a/redhat/configs/priority.fedora b/redhat/configs/priority.fedora
index blahblah..blahblah 100644
--- a/redhat/configs/priority.fedora
+++ b/redhat/configs/priority.fedora
@@ -16,7 +16,7 @@
# kernel.config files are build on the fly based on this config,
# the first arg is arch and variant, the second is a hierarchy of
# config options, lowest priority to highest
-ORDER=common pending-common fedora pending-fedora custom-overrides
+ORDER=common fedora pending-fedora custom-overrides
EMPTY=s390x-zfcpdump
# x86_64
diff --git a/redhat/configs/priority.rhel b/redhat/configs/priority.rhel
index blahblah..blahblah 100644
--- a/redhat/configs/priority.rhel
+++ b/redhat/configs/priority.rhel
@@ -16,7 +16,7 @@
# kernel.config files are build on the fly based on this config,
# the first arg is arch and variant, the second is a hierarchy of
# config options, lowest priority to highest
-ORDER=common ark pending-common custom-overrides
+ORDER=common ark pending-ark custom-overrides
EMPTY=armv7hl armv7hl-debug armv7hl-lpae armv7hl-lpae-debug i686 i686-debug
# x86_64
diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh
index blahblah..blahblah 100755
--- a/redhat/configs/process_configs.sh
+++ b/redhat/configs/process_configs.sh
@@ -388,16 +388,15 @@ done
PACKAGE_NAME="${1:-kernel}" # defines the package name used
KVERREL="$(test -n "$2" && echo "-$2" || echo "")"
SUBARCH="$(test -n "$3" && echo "-$3" || echo "")"
-FLAVOR="$(test -n "$4" && echo "-$4" || echo "-common")"
+FLAVOR="$(test -n "$4" && echo "-$4" || echo "-ark")"
RHJOBS="$(test -n "$5" && echo "$5" || nproc --all)"
SCRIPT=$(readlink -f "$0")
SCRIPT_DIR=$(dirname "$SCRIPT")
-# Most RHEL options are options we want in Fedora so RHEL pending settings head
-# to common/
+# Config options for RHEL should target the pending-ark directory, not pending-common.
if [ "$FLAVOR" = "-rhel" ]
then
- FLAVOR="-common"
+ FLAVOR="-ark"
fi
# to handle this script being a symlink
diff --git a/redhat/docs/faq.rst b/redhat/docs/faq.rst
index blahblah..blahblah 100644
--- a/redhat/docs/faq.rst
+++ b/redhat/docs/faq.rst
@@ -22,13 +22,13 @@ bleeding edge.
----------------------------------------------------------
During the -rc1 and -rc2 phase, this is not uncommon. Most configs should
-be autogenerated to defaults and placed in pending-common until an official
+be autogenerated to defaults and placed in pending-ark until an official
review has taken place.
Occassionally during the review cycle, the default changes and new configs
are revealed that are not autogenerated and leads to unresolved configs.
-Creating a file under redhat/configs/pending-common/ with the config
+Creating a file under redhat/configs/pending-ark/ with the config
settings necessary should temporarily resolve this until the maintainers can
resolve this properly.
diff --git a/redhat/docs/repository-layout.rst b/redhat/docs/repository-layout.rst
index blahblah..blahblah 100644
--- a/redhat/docs/repository-layout.rst
+++ b/redhat/docs/repository-layout.rst
@@ -134,8 +134,8 @@ A flavor is defined by:
configuration directories and should include the directory you
defined in step 2.
-common and common-pending
-~~~~~~~~~~~~~~~~~~~~~~~~~
+common and pending-ark
+~~~~~~~~~~~~~~~~~~~~~~
The ``common`` directory contains configuration values that are shared
across all configuration "flavors". For a configuration to be in
@@ -145,19 +145,19 @@ can override settings in ``common``, so it's not guaranteed settings in
common are the same across all flavors. It's simply a good place to set
common values across the flavors and use as a base for new flavors.
-``common-pending`` is where configuration options that have not been
+``pending-ark`` is where configuration options that have not been
reviewed are placed. Automation creates snippets for all new
configuration options exposed during a rebase of ARK in the
-``pending-common`` directory, at which point subsystem maintainers
+``pending-ark`` directory, at which point subsystem maintainers
review the options and set them as appropriate before moving them into
``common``.
-New ARK configurations are placed in ``common-pending`` because it is
+New ARK configurations are placed in ``pending-ark`` because it is
assumed that ARK generally has the most conservative settings, whereas
other flavors like Fedora will be (for the most part) a superset of the
ARK configuration.
-fedora and fedora-pending
+fedora and pending-fedora
~~~~~~~~~~~~~~~~~~~~~~~~~
The ``fedora`` directory contains settings that have been reviewed by
@@ -168,6 +168,6 @@ rebase to expose new configuration options that only apply to Fedora.
For this reason, Fedora has a ``pending-fedora`` directory as well.
``pending-fedora`` contains settings that are not exposed by the
``common`` configuration set and only apply to Fedora. It is, like
-``pending-common``, populated automatically during a rebase. A Fedora
+``pending-ark``, populated automatically during a rebase. A Fedora
kernel maintain can review the settings at their leisure and move them
over to ``fedora`` as they do so.
diff --git a/redhat/gen_config_patches.sh b/redhat/gen_config_patches.sh
index blahblah..blahblah 100755
--- a/redhat/gen_config_patches.sh
+++ b/redhat/gen_config_patches.sh
@@ -107,13 +107,13 @@ for f in "$config_bundles_dir"/*; do
# This loop actually grabs the help text to put in the commit
while read -r line; do
# last line is the actual config we need to put in the dir
- tail -n 1 redhat/configs/pending-common/generic/"$line" > redhat/configs/common/generic/"$line"
+ tail -n 1 redhat/configs/pending-ark/generic/"$line" > redhat/configs/ark/generic/"$line"
# get everything except the last line for the commit text
- head -n -1 redhat/configs/pending-common/generic/"$line" | sed -e 's/^#//g' >> "$tmpdir"/commit
+ head -n -1 redhat/configs/pending-ark/generic/"$line" | sed -e 's/^#//g' >> "$tmpdir"/commit
# add a nice separator that renders in gitlab
echo -ne "\n---\n\n" >> "$tmpdir"/commit
# remove the pending option
- rm redhat/configs/pending-common/generic/"$line"
+ rm redhat/configs/pending-ark/generic/"$line"
done < "$f"
if [ -n "$RHMAINTAINERS" ] && [ -f ./scripts/get_maintainer.pl ] && [ -f "$RHMAINTAINERS" ]; then
echo "" >> "$tmpdir"/commit
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1622
2Β years, 1Β month
β FAIL: Test report for kernel 5.16.13-200.fc35 (fedora-35)
by CKI Project
Hello,
We ran automated tests on the following kernel build:
Kernel package: kernel-5.16.13-200.fc35
Task URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=83862962
The results of these automated tests are provided below.
Overall result: FAILED (see details below)
Tests: FAILED
One or more kernel tests failed:
s390x:
β LTP - syscalls
All kernel binaries, config files, and logs are available for download here:
https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?pre...
Please reply to this email if you have any questions about the tests that we
ran or if you have any suggestions on how to make future tests more effective.
For the full detail on our testing procedures, please scroll to the bottom of
this message.
,-. ,-.
( C ) ( K ) Continuous
`-',-.`-' Kernel
( I ) Integration
`-'
______________________________________________________________________________
Hardware testing
----------------
We booted each kernel and ran the following tests:
aarch64:
Host 1:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β
SELinux Custom Module Setup
β
Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - nvmeof-mp
Host 2:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - srp
Host 3:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ xfstests - ext4
β‘β‘β‘ xfstests - xfs
β‘β‘β‘ lvm thinp sanity
β‘β‘β‘ Storage: swraid mdadm raid_module test
π§ β‘β‘β‘ xfstests - btrfs
π§ β‘β‘β‘ Storage blktests - blk
π§ β‘β‘β‘ Storage blktests - nvme-tcp
π§ β‘β‘β‘ Storage block - filesystem fio test
π§ β‘β‘β‘ Storage block - queue scheduler test
π§ β‘β‘β‘ Storage block - storage fio numa
π§ β‘β‘β‘ storage: software RAID testing
π§ β‘β‘β‘ stress: stress-ng - interrupt
π§ β‘β‘β‘ stress: stress-ng - cpu
π§ β‘β‘β‘ stress: stress-ng - cpu-cache
π§ β‘β‘β‘ stress: stress-ng - memory
π§ β‘β‘β‘ stress: stress-ng - os
Host 4:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ ACPI table test
β‘β‘β‘ LTP - cve
β‘β‘β‘ LTP - sched
β‘β‘β‘ LTP - syscalls
β‘β‘β‘ LTP - can
β‘β‘β‘ LTP - commands
β‘β‘β‘ LTP - containers
β‘β‘β‘ LTP - dio
β‘β‘β‘ LTP - fs
β‘β‘β‘ LTP - fsx
β‘β‘β‘ LTP - math
β‘β‘β‘ LTP - hugetlb
β‘β‘β‘ LTP - mm
β‘β‘β‘ LTP - nptl
β‘β‘β‘ LTP - pty
β‘β‘β‘ LTP - ipc
β‘β‘β‘ LTP - tracing
β‘β‘β‘ LTP: openposix test suite
β‘β‘β‘ CIFS Connectathon
β‘β‘β‘ Loopdev Sanity
β‘β‘β‘ Memory: fork_mem
β‘β‘β‘ Memory function: memfd_create
β‘β‘β‘ AMTU (Abstract Machine Test Utility)
β‘β‘β‘ Ethernet drivers sanity
π§ β‘β‘β‘ NFS Connectathon
ppc64le:
Host 1:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
β
xfstests - ext4
β
xfstests - xfs
β
lvm thinp sanity
β
Storage: swraid mdadm raid_module test
π§ β
xfstests - btrfs
π§ β
Storage blktests - blk
π§ β
Storage blktests - nvme-tcp
π§ β
Storage block - filesystem fio test
π§ β
Storage block - queue scheduler test
π§ β
Storage block - storage fio numa
π§ β
Storage: lvm device-mapper test - upstream
π§ β
storage: software RAID testing
Host 2:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
β
LTP - cve
β
LTP - sched
β
LTP - syscalls
β
LTP - can
β
LTP - commands
β
LTP - containers
β
LTP - dio
β
LTP - fs
β
LTP - fsx
β
LTP - math
β
LTP - hugetlb
β
LTP - mm
β
LTP - nptl
β
LTP - pty
β
LTP - ipc
β
LTP - tracing
β
LTP: openposix test suite
β
CIFS Connectathon
β
Loopdev Sanity
β
Memory: fork_mem
β
Memory function: memfd_create
β
AMTU (Abstract Machine Test Utility)
β
Ethernet drivers sanity
π§ β xarray-idr-radixtree-test
π§ β
NFS Connectathon
Host 3:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - nvmeof-mp
Host 4:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
π§ β
Storage blktests - srp
Host 5:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - nvmeof-mp
Host 6:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
π§ β
Storage blktests - nvmeof-mp
s390x:
Host 1:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
β
LTP - cve
β
LTP - sched
β LTP - syscalls
β
LTP - can
β
LTP - commands
β
LTP - containers
β
LTP - dio
β
LTP - fs
β
LTP - fsx
β
LTP - math
β
LTP - hugetlb
β
LTP - mm
β
LTP - nptl
β
LTP - pty
β
LTP - ipc
β
LTP - tracing
β
LTP: openposix test suite
β
CIFS Connectathon
β
Loopdev Sanity
β
Memory: fork_mem
β
Memory function: memfd_create
β
AMTU (Abstract Machine Test Utility)
β
Ethernet drivers sanity
π§ β
NFS Connectathon
Host 2:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
π§ β
Storage blktests - nvmeof-mp
Host 3:
π§ β
SELinux Custom Module Setup
β
Boot test
β
Reboot test
β
Storage: swraid mdadm raid_module test
π§ β Storage blktests - blk
π§ β
Storage blktests - nvme-tcp
π§ β
stress: stress-ng - interrupt
π§ β
stress: stress-ng - cpu
π§ β
stress: stress-ng - cpu-cache
π§ β
stress: stress-ng - memory
π§ β
stress: stress-ng - os
x86_64:
Host 1:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ xfstests - ext4
β‘β‘β‘ xfstests - xfs
β‘β‘β‘ xfstests - nfsv4.2
β‘β‘β‘ lvm thinp sanity
β‘β‘β‘ Storage: swraid mdadm raid_module test
π§ β‘β‘β‘ xfstests - btrfs
π§ β‘β‘β‘ xfstests - cifsv3.11
π§ β‘β‘β‘ Storage blktests - blk
π§ β‘β‘β‘ Storage blktests - nvme-tcp
π§ β‘β‘β‘ Storage block - filesystem fio test
π§ β‘β‘β‘ Storage block - queue scheduler test
π§ β‘β‘β‘ Storage block - storage fio numa
π§ β‘β‘β‘ Storage: lvm device-mapper test - upstream
π§ β‘β‘β‘ storage: software RAID testing
π§ β‘β‘β‘ stress: stress-ng - interrupt
π§ β‘β‘β‘ stress: stress-ng - cpu
π§ β‘β‘β‘ stress: stress-ng - cpu-cache
π§ β‘β‘β‘ stress: stress-ng - memory
π§ β‘β‘β‘ stress: stress-ng - os
Host 2:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
π§ β‘β‘β‘ Storage blktests - nvmeof-mp
Host 3:
β‘ Internal infrastructure issues prevented one or more tests (marked
with β‘β‘β‘) from running on this architecture.
This is not the fault of the kernel that was tested.
π§ β‘β‘β‘ SELinux Custom Module Setup
β‘β‘β‘ Boot test
β‘β‘β‘ Reboot test
β‘β‘β‘ ACPI table test
β‘β‘β‘ LTP - cve
β‘β‘β‘ LTP - sched
β‘β‘β‘ LTP - syscalls
β‘β‘β‘ LTP - can
β‘β‘β‘ LTP - commands
β‘β‘β‘ LTP - containers
β‘β‘β‘ LTP - dio
β‘β‘β‘ LTP - fs
β‘β‘β‘ LTP - fsx
β‘β‘β‘ LTP - math
β‘β‘β‘ LTP - hugetlb
β‘β‘β‘ LTP - mm
β‘β‘β‘ LTP - nptl
β‘β‘β‘ LTP - pty
β‘β‘β‘ LTP - ipc
β‘β‘β‘ LTP - tracing
β‘β‘β‘ LTP: openposix test suite
β‘β‘β‘ CIFS Connectathon
β‘β‘β‘ Loopdev Sanity
β‘β‘β‘ Memory: fork_mem
β‘β‘β‘ Memory function: memfd_create
β‘β‘β‘ AMTU (Abstract Machine Test Utility)
β‘β‘β‘ Ethernet drivers sanity
π§ β‘β‘β‘ xarray-idr-radixtree-test
π§ β‘β‘β‘ NFS Connectathon
Test sources: https://gitlab.com/cki-project/kernel-tests
π Pull requests are welcome for new tests or improvements to existing tests!
Aborted tests
-------------
Tests that didn't complete running successfully are marked with β‘β‘β‘.
If this was caused by an infrastructure issue, we try to mark that
explicitly in the report.
Waived tests
------------
If the test run included waived tests, they are marked with π§. Such tests are
executed but their results are not taken into account. Tests are waived when
their results are not reliable enough, e.g. when they're just introduced or are
being fixed.
Testing timeout
---------------
We aim to provide a report within reasonable timeframe. Tests that haven't
finished running yet are marked with β±.
2Β years, 1Β month
[OS-BUILD PATCHv7 0/9] process_configs.sh: Add parallel processing of
configs
in dist-configs
by Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635
The dist-configs target takes an annoying long time.
Add parallel processing of configs in dist-configs.
Testing Info
------------
make dist-configs time 1m22.909s
make -j20 dist-configs time 11.801s
Removed redhat/configs/common/generic/x86/x86_64/CONFIG_ACPI_HOTPLUG_MEMORY
to test unset error.
>Found unset config items in x86_64-debug, please set them to an appropriate
value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
>Found unset config items in x86_64-kgcov, please set them to an appropriate
value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
>Found unset config items in x86_64, please set them to an appropriate value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
Changed redhat/configs/common/generic/s390x/CONFIG_HID from 'is not set'
to '=n' to test mismatch error.
>Error: Mismatches found in configuration files for s390x-debug
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x-kgcov
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x-zfcpdump
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>make[1]: *** [Makefile:128: dist-configs] Error 1
Changed redhat/configs/common/generic/CONFIG_PREEMPT to '=y' to test
misconfigured error.
>Found misconfigured config items in aarch64-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64-debug.config.orig:4245:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in aarch64-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64-kgcov.config.orig:4224:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in ppc64le-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-5.17.0-ppc64le-
kgcov.config.orig:4028:warning: override: PREEMPT changes choice state
>Found misconfigured config items in ppc64le, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-ppc64le.config.orig:4026:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in x86_64-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64-debug.config.orig:4212:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in x86_64-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64-kgcov.config.orig:4192:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in x86_64, please set them to an appropriate
value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64.config.orig:4190:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in aarch64, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64.config.orig:4222:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in ppc64le-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-5.17.0-ppc64le-
debug.config.orig:4045:warning: override: PREEMPT changes choice state
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
---
redhat/configs/build_configs.sh | 35 ++++++-
redhat/configs/process_configs.sh | 165 ++++++++++++++++++++++++-------------
redhat/Makefile | 22 +++-
3 files changed, 147 insertions(+), 75 deletions(-)
2Β years, 1Β month
[OS-BUILD PATCHv3] mm/sparsemem: Fix 'mem_section' will never be NULL
gcc 12
warning
by Justin M. Forbes (via Email Bridge)
From: Waiman Long <longman(a)redhat.com>
mm/sparsemem: Fix 'mem_section' will never be NULL gcc 12 warning
The gcc 12 compiler reports a "'mem_section' will never be NULL"
warning on the following code:
static inline struct mem_section *__nr_to_section(unsigned long nr)
{
#ifdef CONFIG_SPARSEMEM_EXTREME
if (!mem_section)
return NULL;
#endif
if (!mem_section[SECTION_NR_TO_ROOT(nr)])
return NULL;
:
It happens with both CONFIG_SPARSEMEM_EXTREME on and off. The mem_section
definition is
#ifdef CONFIG_SPARSEMEM_EXTREME
extern struct mem_section **mem_section;
#else
extern struct mem_section mem_section[NR_SECTION_ROOTS][SECTIONS_PER_ROOT];
#endif
In the CONFIG_SPARSEMEM_EXTREME case, mem_section obviously cannot
be NULL, but *mem_section can be if memory hasn't been allocated for
the dynamic mem_section[] array yet. In the !CONFIG_SPARSEMEM_EXTREME
case, mem_section is a static 2-dimensional array and so the check
"!mem_section[SECTION_NR_TO_ROOT(nr)]" doesn't make sense.
Fix this warning by checking for "!*mem_section" instead of
"!mem_section" and moving the "!mem_section[SECTION_NR_TO_ROOT(nr)]"
check up inside the CONFIG_SPARSEMEM_EXTREME block.
Fixes: 83e3c48729d9 ("mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y")
Fixes: 3e347261a80b ("sparsemem extreme implementation")
Reported-by: Justin Forbes <jforbes(a)redhat.com>
Signed-off-by: Waiman Long <longman(a)redhat.com>
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index blahblah..blahblah 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -1390,11 +1390,9 @@ static inline unsigned long *section_to_usemap(struct mem_section *ms)
static inline struct mem_section *__nr_to_section(unsigned long nr)
{
#ifdef CONFIG_SPARSEMEM_EXTREME
- if (!mem_section)
+ if (!*mem_section || !mem_section[SECTION_NR_TO_ROOT(nr)])
return NULL;
#endif
- if (!mem_section[SECTION_NR_TO_ROOT(nr)])
- return NULL;
return &mem_section[SECTION_NR_TO_ROOT(nr)][nr & SECTION_ROOT_MASK];
}
extern size_t mem_section_usage_size(void);
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1598
2Β years, 1Β month
[OS-BUILD PATCHv3 0/0] Add Partner Supported taint flag
by Alice Mitchell (via Email Bridge)
From: Alice Mitchell on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603
NOTE: Truncated patchset due to missing public @redhat.com email
address on your GitLab profile at https://gitlab.com/-/profile.
Once that is fixed, close and reopen the merge request to
retrigger sending the emails.
This is to add a new kernel taint flag that indicates that this
is a Partner Supported GPL module and not directly Supported
by Red Hat, as per the policy document for partner Supported
upstream kernel modules as linked from the bugzilla.
Use of rh_flags is deemed not appropriate in this case as that mechanism was
developed with the intent of not tainting the kernel in a common scenario,
where as in this case this taint flag
1. is for a rare scenario so we need high visibility on it
2. will trigger a different support workflow
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2038999
Upstream Status: RHEL only
Signed-off-by: Alice Mitchell <ajmitchell(a)redhat.com>
---
fs/afs/main.c | 3 +++
include/linux/panic.h | 2 +-
kernel/panic.c | 2 +-
kernel/rh_messages.c | 30 ++++++++++++++++++++++++++++++
4 files changed, 35 insertions(+), 2 deletions(-)
2Β years, 1Β month
[OS-BUILD PATCHv5 0/4] Sync support status with RHEL9 and updates to
new
messaging
by pjgeorg (via Email Bridge)
From: pjgeorg on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1610
Some details about this series:
* Commits 06218335 to e1eb4b24 forward port commits to use new messaging
introduced in cf796e6a.
* Commits d5867f81 to 3f858e49 add missing #ifdef CONFIG_RHEL_DIFFERENCES
guards.
* Commit 47f7c2f5 fixes a typo in cf796e6a.
* Commits efeb0057 to 0f1c6113 update a few more drivers to use the new
messaging introduced in cf796e6a.
Commits 5aec7a92, 02a4b827 and 67f77726 could be further improved. All of
these still silently drop PCI IDs with no messaging at all.
Downstream commit [ce5b1ff71108d] is not included as these modules have
already been disabled in 48086994.
Downstream MR [489] is also not included as it has not been merged yet.
[ce5b1ff71108d]: https://gitlab.com/redhat/centos-stream/src/kernel/centos-
stream-9/-/commit/ce5b1ff71108d
[489]: https://gitlab.com/redhat/centos-stream/src/kernel/centos-
stream-9/-/merge_requests/489
!1504 contains some changes also included in this MR.
---
arch/x86/kernel/setup.c | 2 --
drivers/net/ethernet/intel/e1000/e1000_main.c | 2 --
drivers/net/team/team.c | 2 --
drivers/net/wireguard/main.c | 1 -
drivers/virtio/virtio_mem.c | 13 -------------
fs/ext4/super.c | 5 -----
fs/xfs/xfs_super.c | 5 -----
include/linux/kernel.h | 2 +-
mm/cma.c | 10 ----------
9 files changed, 1 insertions(+), 41 deletions(-)
2Β years, 1Β month
[OS-BUILD PATCHv6 0/9] process_configs.sh: Add parallel processing of
configs
in dist-configs
by Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635
The dist-configs target takes an annoying long time.
Add parallel processing of configs in dist-configs.
Testing Info
------------
make dist-configs time 1m22.909s
make -j20 dist-configs time 11.801s
Removed redhat/configs/common/generic/x86/x86_64/CONFIG_ACPI_HOTPLUG_MEMORY
to test unset error.
>Found unset config items in x86_64-debug, please set them to an appropriate
value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
>Found unset config items in x86_64-kgcov, please set them to an appropriate
value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
>Found unset config items in x86_64, please set them to an appropriate value
>CONFIG_ACPI_HOTPLUG_MEMORY=n
Changed redhat/configs/common/generic/s390x/CONFIG_HID from 'is not set'
to '=n' to test mismatch error.
>Error: Mismatches found in configuration files for s390x-debug
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x-kgcov
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x-zfcpdump
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>Error: Mismatches found in configuration files for s390x
>Found # CONFIG_HID is not set, after generation, had CONFIG_HID n in Source
tree
>make[1]: *** [Makefile:128: dist-configs] Error 1
Changed redhat/configs/common/generic/CONFIG_PREEMPT to '=y' to test
misconfigured error.
>Found misconfigured config items in aarch64-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64-debug.config.orig:4245:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in aarch64-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64-kgcov.config.orig:4224:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in ppc64le-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-5.17.0-ppc64le-
kgcov.config.orig:4028:warning: override: PREEMPT changes choice state
>Found misconfigured config items in ppc64le, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-ppc64le.config.orig:4026:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in x86_64-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64-debug.config.orig:4212:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in x86_64-kgcov, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64-kgcov.config.orig:4192:warning:
override: PREEMPT changes choice state
>Found misconfigured config items in x86_64, please set them to an appropriate
value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-x86_64.config.orig:4190:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in aarch64, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-
ark/redhat/configs/kernel-5.17.0-aarch64.config.orig:4222:warning: override:
PREEMPT changes choice state
>Found misconfigured config items in ppc64le-debug, please set them to an
appropriate value
>/home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-5.17.0-ppc64le-
debug.config.orig:4045:warning: override: PREEMPT changes choice state
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
---
redhat/configs/build_configs.sh | 35 ++++++-
redhat/configs/process_configs.sh | 163 ++++++++++++++++++++++++-------------
redhat/Makefile | 22 +++-
3 files changed, 145 insertions(+), 75 deletions(-)
2Β years, 2Β months
[OS-BUILD PATCHv5 0/2] redhat/genspec.sh: Remove options and use
Makefile
variables
by Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638
genspec.sh has _22_ parameters that must be specified on the command line
which are generated by the Makefile. These parameters can be set in the
script by using the output of the dist-dump-variables target which
simplifies the genspec.sh script.
In addition to that, and as fall-out from this change, use common
names in genspec.sh (which come from the Makefile), and
kernel.spec.template.
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>
---
redhat/Makefile | 4 ++-
redhat/genspec.sh | 53 +++++++++++---------------------------------
redhat/kernel.spec.template | 16 ++++++------
3 files changed, 25 insertions(+), 48 deletions(-)
2Β years, 2Β months