From: Prarit Bhargava prarit@redhat.com
redhat/configs: Enable CRYPTO_CURVE25519 in ark
Enable CRYPTO_CURVE25519 in ark based on the feedback from a previous merge request [1]. This requires a minor cleanup of the fedora and ark generic files.
[1] https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_r... Signed-off-by: Prarit Bhargava prarit@redhat.com
diff --git a/redhat/configs/ark/generic/CONFIG_CRYPTO_CURVE25519 b/redhat/configs/ark/generic/s390x/zfcpdump/CONFIG_CRYPTO_CURVE25519 rename from redhat/configs/ark/generic/CONFIG_CRYPTO_CURVE25519 rename to redhat/configs/ark/generic/s390x/zfcpdump/CONFIG_CRYPTO_CURVE25519 index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/CONFIG_CRYPTO_CURVE25519 +++ b/redhat/configs/ark/generic/s390x/zfcpdump/CONFIG_CRYPTO_CURVE25519 diff --git a/redhat/configs/fedora/generic/CONFIG_CRYPTO_CURVE25519 b/redhat/configs/common/CONFIG_CRYPTO_CURVE25519 rename from redhat/configs/fedora/generic/CONFIG_CRYPTO_CURVE25519 rename to redhat/configs/common/CONFIG_CRYPTO_CURVE25519 index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/CONFIG_CRYPTO_CURVE25519 +++ b/redhat/configs/common/CONFIG_CRYPTO_CURVE25519
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1212971...
Thanks. Fixed.
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1216378...
@NefigTut, @omos, @prauld review please.
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1216392...
@jmflinuxtx - hmm, did we agree to avoid touching common and only let a bot do that?
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1216465...
That is the general guidance so that we do not end up with uncommon items in common, though this change is correct use of common, and where it would end up anyway.
From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1216520...
The `common` config file path is missing `generic` after `common` in this version. I believe that is also why the pipeline failed.
From: Vladis Dronov on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2225#note_1226412...
agreed with Ondrej, the path in a second chunk is not correct. it should be:
redhat/configs/fedora/generic/CONFIG_CRYPTO_CURVE25519 -> redhat/configs/common/generic/CONFIG_CRYPTO_CURVE25519
kernel@lists.fedoraproject.org
-
Don Zickus (via Email Bridge) -
Justin M. Forbes (via Email Bridge)
-
Ondrej Mosnáček (via Email Bridge)
-
Prarit Bhargava (via Email Bridge)
-
Vladis Dronov (via Email Bridge)