12:20 p.m.
From: "Justin M. Forbes" <jforbes(a)fedoraproject.org>
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_INET6_ESPINTCP:
Support for RFC 8229 encapsulation of ESP and IKE over
TCP/IPv6 sockets.
If unsure, say N.
Symbol: INET6_ESPINTCP [=n]
Type : bool
Defined at net/ipv6/Kconfig:91
Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
Location:
-> Networking support (NET [=y])
-> Networking options
-> TCP/IP networking (INET [=y])
-> The IPv6 protocol (IPV6 [=y])
-> IPv6: ESP transformation (INET6_ESP [=m])
Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
---
Signed-off-by: Justin M. Forbes <jforbes(a)fedoraproject.org>
---
.../common/generic/CONFIG_INET6_ESPINTCP | 1 +
.../generic/CONFIG_INET6_ESPINTCP | 23 -------------------
2 files changed, 1 insertion(+), 23 deletions(-)
create mode 100644 redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
diff --git a/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
new file mode 100644
index 000000000000..1b4ebe140e27
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
deleted file mode 100644
index b25df3812966..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_INET6_ESPINTCP:
-#
-# Support for RFC 8229 encapsulation of ESP and IKE over
-# TCP/IPv6 sockets.
-#
-# If unsure, say N.
-#
-# Symbol: INET6_ESPINTCP [=n]
-# Type : bool
-# Defined at net/ipv6/Kconfig:91
-# Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
-# Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
-# Location:
-# -> Networking support (NET [=y])
-# -> Networking options
-# -> TCP/IP networking (INET [=y])
-# -> The IPv6 protocol (IPV6 [=y])
-# -> IPv6: ESP transformation (INET6_ESP [=m])
-# Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
-#
-#
-#
-# CONFIG_INET6_ESPINTCP is not set
--
2.26.2
2:15 p.m.
On Thu, 04 Jun 2020 17:20:21 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
Please set to y.
I talked with Sabrina, she pointed out that this complements
CONFIG_INET_ESPINTCP that we have enabled in ARK.
Nacked-by: Jiri Benc <jbenc(a)redhat.com>
Thanks,
Jiri
8:46 a.m.
New subject: [OS-BUILD PATCHv2] New configs in net/ipv6
From: "Justin M. Forbes" <jforbes(a)fedoraproject.org>
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_INET6_ESPINTCP:
Support for RFC 8229 encapsulation of ESP and IKE over
TCP/IPv6 sockets.
If unsure, say N.
Symbol: INET6_ESPINTCP [=n]
Type : bool
Defined at net/ipv6/Kconfig:91
Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
Location:
-> Networking support (NET [=y])
-> Networking options
-> TCP/IP networking (INET [=y])
-> The IPv6 protocol (IPV6 [=y])
-> IPv6: ESP transformation (INET6_ESP [=m])
Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
Cc: Jiri Benc <jbenc(a)redhat.com>
Cc: Marcelo Leitner <mleitner(a)redhat.com>
Cc: Davide Caratti <dcaratti(a)redhat.com>
Cc: Eric Garver <egarver(a)redhat.com>
Cc: Flavio Leitner <fbl(a)redhat.com>
Cc: Florian Westphal <fwestpha(a)redhat.com>
Cc: Guillaume Nault <gnault(a)redhat.com>
Cc: Hangbin Liu <haliu(a)redhat.com>
Cc: Ivan Vecera <ivecera(a)redhat.com>
Cc: Jarod Wilson <jarod(a)redhat.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi(a)redhat.com>
Cc: Paolo Abeni <pabeni(a)redhat.com>
Cc: Phil Sutter <psutter(a)redhat.com>
Cc: Sabrina Dubroca <sdubroca(a)redhat.com>
Cc: Stefano Brivio <sbrivio(a)redhat.com>
Cc: Xin Long <lxin(a)redhat.com>
Cc: Neil Horman <nhorman(a)redhat.com>
Cc: Matteo Croce <mcroce(a)redhat.com>
---
.../common/generic/CONFIG_INET6_ESPINTCP | 1 +
.../generic/CONFIG_INET6_ESPINTCP | 23 -------------------
2 files changed, 1 insertion(+), 23 deletions(-)
create mode 100644 redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
diff --git a/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
new file mode 100644
index 000000000000..1b4ebe140e27
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
deleted file mode 100644
index b25df3812966..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_INET6_ESPINTCP:
-#
-# Support for RFC 8229 encapsulation of ESP and IKE over
-# TCP/IPv6 sockets.
-#
-# If unsure, say N.
-#
-# Symbol: INET6_ESPINTCP [=n]
-# Type : bool
-# Defined at net/ipv6/Kconfig:91
-# Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
-# Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
-# Location:
-# -> Networking support (NET [=y])
-# -> Networking options
-# -> TCP/IP networking (INET [=y])
-# -> The IPv6 protocol (IPV6 [=y])
-# -> IPv6: ESP transformation (INET6_ESP [=m])
-# Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
-#
-#
-#
-# CONFIG_INET6_ESPINTCP is not set
--
GitLab
9:16 a.m.
New subject: [OS-BUILD PATCHv2] New configs in net/ipv6
On Wed, 30 Sep 2020 13:46:41 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
We have CONFIG_INET_ESPINTCP enabled, so this should be enabled, too.
Unless Sabrina objects :-)
Jiri
10:23 a.m.
New subject: [OS-BUILD PATCHv2] New configs in net/ipv6
On Wed, Sep 30, 2020 at 04:16:46PM +0200, Jiri Benc wrote:
On Wed, 30 Sep 2020 13:46:41 -0000, GitLab Bridge on behalf of
jmflinuxtx wrote:
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
> @@ -0,0 +1 @@
> +# CONFIG_INET6_ESPINTCP is not set
We have CONFIG_INET_ESPINTCP enabled, so this should be enabled, too.
Unless Sabrina objects :-)
As she didn't, can we please flip this to yes?
Also, because we have it =y on RHEL8 since
2bce03d036c5 ("[redhat] enable CONFIG_INET6_ESPINTCP")
Marcelo
10:26 a.m.
New subject: [OS-BUILD PATCHv3 0/2] [redhat] New configs in net/ipv6
From: jmflinuxtx on gitlab.com
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_INET6_ESPINTCP:
Support for RFC 8229 encapsulation of ESP and IKE over
TCP/IPv6 sockets.
If unsure, say N.
Symbol: INET6_ESPINTCP [=n]
Type : bool
Defined at net/ipv6/Kconfig:91
Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&&
INET6_ESP [=m]
Location:
-> Networking support (NET [=y])
-> Networking options
-> TCP/IP networking (INET [=y])
-> The IPv6 protocol (IPV6 [=y])
-> IPv6: ESP transformation (INET6_ESP [=m])
Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
---
Signed-off-by: Justin M. Forbes <jforbes(a)fedoraproject.org>
10:26 a.m.
New subject: [OS-BUILD PATCHv3 2/2] Update CONFIG_INET6_ESPINTCP
From: Justin Forbes <jforbes(a)fedoraproject.org>
---
redhat/configs/common/generic/CONFIG_INET6_ESPINTCP | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
index 1b4ebe140e27..9205e18543d6 100644
--- a/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -1 +1 @@
-# CONFIG_INET6_ESPINTCP is not set
+CONFIG_INET6_ESPINTCP=y
--
GitLab
3:04 a.m.
New subject: [OS-BUILD PATCHv3 2/2] Update CONFIG_INET6_ESPINTCP
On Thu, 29 Oct 2020 15:26:53 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
From: Justin Forbes <jforbes(a)fedoraproject.org>
Justin, formatting the commits this way is really making our future
life harder. Could you please:
1. Submit a single patch instead of this mess of first setting the
config option to no, only to flip it to yes right after?
2. Include a reason on why the config option is set in the way it is?
Something like: "As requested by Jiri Benc <jbenc(a)redhat.com>" would
be totally enough.
I'm very sure both of these points can be easily automated.
Thank you.
Jiri
10:46 a.m.
New subject: [OS-BUILD PATCHv3 2/2] Update CONFIG_INET6_ESPINTCP
On Mon, Nov 2, 2020 at 3:04 AM Jiri Benc <jbenc(a)redhat.com> wrote:
On Thu, 29 Oct 2020 15:26:53 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
> From: Justin Forbes <jforbes(a)fedoraproject.org>
Justin, formatting the commits this way is really making our future
life harder. Could you please:
1. Submit a single patch instead of this mess of first setting the
config option to no, only to flip it to yes right after?
The reason I agreed to make the changes was because it could be done
in a matter of seconds in the web UI as opposed to checking out the
branch, making the change, and doing a force change. I really have
enough on my plate without adding that.
2. Include a reason on why the config option is set in the way it
is?
Something like: "As requested by Jiri Benc <jbenc(a)redhat.com>" would
be totally enough.
That, I am happy to do.
I'm very sure both of these points can be easily automated.
If someone would like to automate it, that's great. At the moment I am
managing every Fedora release, and a good bit of ARK. hopefully some
help is coming that will take some of the ARK specific work off of my
plate, but until then, it is actually a lot to ask. The reason I
agreed to do it was because a) it could be done this way in a matter
of seconds in the web ui, and b) otherwise, any config option that was
reviewed and wanting a change was just sitting there, not actually
being changed.
Justin
9:14 a.m.
New subject: [OS-BUILD PATCHv3 2/2] Update CONFIG_INET6_ESPINTCP
On Mon, Nov 2, 2020 at 10:46 AM Justin Forbes <jforbes(a)fedoraproject.org> wrote:
On Mon, Nov 2, 2020 at 3:04 AM Jiri Benc <jbenc(a)redhat.com> wrote:
>
> On Thu, 29 Oct 2020 15:26:53 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
> > From: Justin Forbes <jforbes(a)fedoraproject.org>
>
> Justin, formatting the commits this way is really making our future
> life harder. Could you please:
>
> 1. Submit a single patch instead of this mess of first setting the
> config option to no, only to flip it to yes right after?
The reason I agreed to make the changes was because it could be done
in a matter of seconds in the web UI as opposed to checking out the
branch, making the change, and doing a force change. I really have
enough on my plate without adding that.
Gitlab allows me to "squash commits on merge" which will change these
to a single commit in git history, and should address your concern.
> > 2. Include a reason on why the config option is set in the way it is?
> > Something like: "As requested by Jiri Benc
<jbenc(a)redhat.com>" would
> > be totally enough.
>
> That, I am happy to do.
>
> > I'm very sure both of these points can be easily automated.
> >
>
> If someone would like to automate it, that's great. At the moment I am
> managing every Fedora release, and a good bit of ARK. hopefully some
> help is coming that will take some of the ARK specific work off of my
> plate, but until then, it is actually a lot to ask. The reason I
> agreed to do it was because a) it could be done this way in a matter
> of seconds in the web ui, and b) otherwise, any config option that was
> reviewed and wanting a change was just sitting there, not actually
> being changed.
>
> Justin
9:23 a.m.
New subject: [OS-BUILD PATCHv3 2/2] Update CONFIG_INET6_ESPINTCP
On Tue, 3 Nov 2020 09:14:10 -0600, Justin Forbes wrote:
Gitlab allows me to "squash commits on merge" which will
change these
to a single commit in git history, and should address your concern.
Sounds great, thanks a lot! I appreciate that you're taking time to
look into all of this on top of your other responsibilities.
Don promised we'll get a dedicated maintainer for ARK, fingers crossed.
This should help with improving the process long term.
Thanks,
Jiri
10:26 a.m.
New subject: [OS-BUILD PATCHv3 1/2] New configs in net/ipv6
From: "Justin M. Forbes" <jforbes(a)fedoraproject.org>
Hi,
As part of the ongoing rebase effort, the following configuration
options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply
with a better option.
CONFIG_INET6_ESPINTCP:
Support for RFC 8229 encapsulation of ESP and IKE over
TCP/IPv6 sockets.
If unsure, say N.
Symbol: INET6_ESPINTCP [=n]
Type : bool
Defined at net/ipv6/Kconfig:91
Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
Location:
-> Networking support (NET [=y])
-> Networking options
-> TCP/IP networking (INET [=y])
-> The IPv6 protocol (IPV6 [=y])
-> IPv6: ESP transformation (INET6_ESP [=m])
Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
Cc: Jiri Benc <jbenc(a)redhat.com>
Cc: Marcelo Leitner <mleitner(a)redhat.com>
Cc: Davide Caratti <dcaratti(a)redhat.com>
Cc: Eric Garver <egarver(a)redhat.com>
Cc: Flavio Leitner <fbl(a)redhat.com>
Cc: Florian Westphal <fwestpha(a)redhat.com>
Cc: Guillaume Nault <gnault(a)redhat.com>
Cc: Hangbin Liu <haliu(a)redhat.com>
Cc: Ivan Vecera <ivecera(a)redhat.com>
Cc: Jarod Wilson <jarod(a)redhat.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi(a)redhat.com>
Cc: Paolo Abeni <pabeni(a)redhat.com>
Cc: Phil Sutter <psutter(a)redhat.com>
Cc: Sabrina Dubroca <sdubroca(a)redhat.com>
Cc: Stefano Brivio <sbrivio(a)redhat.com>
Cc: Xin Long <lxin(a)redhat.com>
Cc: Neil Horman <nhorman(a)redhat.com>
Cc: Matteo Croce <mcroce(a)redhat.com>
---
.../common/generic/CONFIG_INET6_ESPINTCP | 1 +
.../generic/CONFIG_INET6_ESPINTCP | 23 -------------------
2 files changed, 1 insertion(+), 23 deletions(-)
create mode 100644 redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
delete mode 100644 redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
diff --git a/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
new file mode 100644
index 000000000000..1b4ebe140e27
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
b/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
deleted file mode 100644
index b25df3812966..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_INET6_ESPINTCP
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_INET6_ESPINTCP:
-#
-# Support for RFC 8229 encapsulation of ESP and IKE over
-# TCP/IPv6 sockets.
-#
-# If unsure, say N.
-#
-# Symbol: INET6_ESPINTCP [=n]
-# Type : bool
-# Defined at net/ipv6/Kconfig:91
-# Prompt: IPv6: ESP in TCP encapsulation (RFC 8229)
-# Depends on: NET [=y] && INET [=y] && IPV6 [=y] && XFRM [=y]
&& INET6_ESP [=m]
-# Location:
-# -> Networking support (NET [=y])
-# -> Networking options
-# -> TCP/IP networking (INET [=y])
-# -> The IPv6 protocol (IPV6 [=y])
-# -> IPv6: ESP transformation (INET6_ESP [=m])
-# Selects: STREAM_PARSER [=y] && NET_SOCK_MSG [=y] && XFRM_ESPINTCP [=y]
-#
-#
-#
-# CONFIG_INET6_ESPINTCP is not set
--
GitLab
10:32 a.m.
New subject: [OS-BUILD PATCHv3 1/2] New configs in net/ipv6
On Thu, Oct 29, 2020 at 03:26:53PM -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
@@ -0,0 +1 @@
+# CONFIG_INET6_ESPINTCP is not set
Seems the =y here is not sticking.
10:34 a.m.
New subject: [OS-BUILD PATCHv3 1/2] New configs in net/ipv6
On Thu, Oct 29, 2020 at 12:32:18PM -0300, Marcelo Ricardo Leitner wrote:
On Thu, Oct 29, 2020 at 03:26:53PM -0000, GitLab Bridge on behalf of
jmflinuxtx wrote:
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_INET6_ESPINTCP
> @@ -0,0 +1 @@
> +# CONFIG_INET6_ESPINTCP is not set
Seems the =y here is not sticking.
Ah, nevermind. Just saw the next patch.
10:36 a.m.
New subject: [OS-BUILD PATCHv3 0/2] [redhat] New configs in net/ipv6
I couldn't find a good part of the cover letter to quote while acking,
to I stripped all out.
Acked-by: Marcelo Ricardo Leitner <mleitner(a)redhat.com>
1270
days inactive
1422
days old
kernel@lists.fedoraproject.org
14 comments
5 participants
participants (5)
-
GitLab Bridge on behalf of jmflinuxtx -
GitLab Bridge on behalf of jmflinuxtx -
Jiri Benc -
Justin Forbes -
Marcelo Ricardo Leitner