On Wed, Feb 12, 2014 at 09:54:26AM +0800, Dave Young wrote:
> check_kdump_feasibility
> rc = $?
> if [ $rc -ne 0 ];then
> echo "Kdump is not supported on this kernel: [WARNING]"
> fi
I prefer to do not say "Kdump is not supported on this kernel" here.
And instead print the detail failure reason in check_kdump_feasibility
function as we agreed for Secure boot checking.
Here in start function if check_kdump_feasibility return non zero I think
it's better to just say "echo "Starting kdump: [FAILED]" as other
chunk.
What do you think?
Sounds reasonable.
Thanks
Vivek