On Fri, Nov 19, 2021 at 02:01:07PM +0800, Coiby Xu wrote:
On Fri, Nov 19, 2021 at 01:31:19PM +0800, Pingfan Liu wrote:
>On Fri, Nov 19, 2021 at 11:22:59AM +0800, Coiby Xu wrote:
>>Factor out kdump_get_arch_recommend_crashkernel to prepare for
>>kdump-anaonda-plugin to retrieve the default crashkernel value.
>>
>
>I am ignorant with the add-on process, and try to assure something.
>-1. Before the installation of kexec-tools.rpm, add-on allows users to pick
kexec-tools and choose kdump/fadump
kdumpctl exist in the running installing system. So we have kdumpctl even before
installing kexec-tools to the target system. Btw, kdump-anaconda-addon
marks kexec-tools as a requirement and don't provide a choice for user
to choose kexec-tools.
>-2. After the installation, there is post-script, which will call
>kdump_get_arch_recommend_crashkernel().
Currently, the value of crashkernel has already been saved in the kdump
window before the installation. After the installing,
kdump-anacond-addon would configure bootloader with the saved
crashkernel.
Sorry I was wrong about the above statement. You are right that the
default crashkernel is obtained after installation is finished.