Patch merged, thanks to Baoquan and Pingfan!
On Thu, Jul 14, 2022 at 09:30:23PM +0800, Pingfan Liu wrote:
On Thu, Jul 14, 2022 at 6:55 PM Baoquan He <bhe(a)redhat.com>
wrote:
>
> Resolves: bz2106645
>
> The code of commit 163c02970e4ddc takes effect in rhel firstly, later
> pulled to Fedora. However, Fedora OS doesn't have 40-redhat.rules
> in systemd-udev package. With this commit applied, a false positive
> warning message can always been seen as below.
>
> So fixing it by checking if 40-redhat.rules exists before handling.
> With this change, the false warning is gone.
>
> [root@ ~]# kdumpctl restart
> kdump: kexec: unloaded kdump kernel
> kdump: Stopping kdump: [OK]
> kdump: No kdump initial ramdisk found.
> kdump: Rebuilding /boot/initramfs-5.19.0-rc6+kdump.img
> sed: can't read
/var/tmp/dracut.NnAV2g/initramfs/usr/lib/udev/rules.d/40-redhat.rules: No such file or
directory
> kdump: kexec: loaded kdump kernel
> kdump: Starting kdump: [OK]
>
> Signed-off-by: Baoquan He <bhe(a)redhat.com>
> ---
> v1->v2:
> Checking the existence of 40-redhat.rule befor handling.
>
> dracut-module-setup.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
> index c319fc2db7aa..4c6096a8df97 100755
> --- a/dracut-module-setup.sh
> +++ b/dracut-module-setup.sh
> @@ -1013,7 +1013,9 @@ kdump_install_systemd_conf() {
> remove_cpu_online_rule() {
> local file=${initdir}/usr/lib/udev/rules.d/40-redhat.rules
>
> - sed -i '/SUBSYSTEM=="cpu"/d' "$file"
> + if [[ -f $file ]]; then
> + sed -i '/SUBSYSTEM=="cpu"/d' "$file"
> + fi
> }
>
> install() {
> --
> 2.34.1
>
LGTM,
Acked-by: Pingfan Liu <piliu(a)redhat.com>
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure