Hello Philipp,
Thanks for reviewing the patch.
On 31/07/23 19:04, Philipp Rudo wrote:
Hi Sourabh,
thanks for the patch. All in all it looks sane to me. There are two
nits/questions I have though.
On Mon, 24 Jul 2023 12:21:19 +0530
Sourabh Jain <sourabhjain(a)linux.ibm.com> wrote:
> In fadump mode, the crashkernel reserved area size cannot be
> obtained from /sys/kernel/kexec_crash_size sysfs node.
>
> The do_estimate function has been modified to use
> /sys/kernel/fadump/mem_reserved to get the reserved area size
> for fadump mode.
>
> Signed-off-by: Sourabh Jain <sourabhjain(a)linux.ibm.com>
> Reported-by: Sachin P Bappalige <sachinpb(a)linux.vnet.ibm.com>
^^^^
1) is this email address correct? I thought the .vnet. addresses were
decommissioned years ago.
I requested the bug reporter to provide his email, and this is what he
gave me.
I will double check with the bug report before sending v2.
2) There are two more places where we read from
/sys/kernel/kexec_crash_size which needs to be fixed (one in
kdumpctl:show_reserved_mem and the other in
kdump-lib.sh:check_crash_mem_reserved). Personally I think it makes
more sense to move the read into a separate function and call that when
in those three locations. This at least prevents the same bug to be
re-introduced in the future.
Sure I will introduce a function to get reserved area based on
the dump mode.
Thanks,
Sourabh