Re: [PATCH 27/47] bash scripts: fix redundant exit code check

On Thu, 12 Aug 2021 13:47:43 +0800 Kairui Song <kasong(a)redhat.com&gt; wrote: > https://github.com/koalaman/shellcheck/wiki/SC2181 > > Signed-off-by: Kairui Song <kasong(a)redhat.com&gt; > --- > dracut-module-setup.sh | 41 ++++++--------- > kdumpctl | 112 +++++++++++++---------------------------- > mkdumprd | 38 ++++---------- > 3 files changed, 60 insertions(+), 131 deletions(-) [...] > diff --git a/mkdumprd b/mkdumprd > index e80ef1b1..0ef358d2 100644 > --- a/mkdumprd > +++ b/mkdumprd > @@ -17,8 +17,7 @@ fi > export IN_KDUMP=1 > > #initiate the kdump logger > -dlog_init > -if [[ $? -ne 0 ]]; then > +if ! dlog_init; then > echo "failed to initiate the kdump logger." > exit 1 > fi > @@ -115,19 +114,13 @@ mkdir_save_path_ssh() > local _opt _dir > _opt="-i $SSH_KEY_LOCATION -o BatchMode=yes -o StrictHostKeyChecking=yes" not actually part of the patch but convert to array like in patch 9/SC2086?