On 2016/06/08 at 10:30, Dave Young wrote:
On 06/06/16 at 05:21pm, Xunlei Pang wrote:
> On 2016/06/06 at 09:34, Xunlei Pang wrote:
>> On 2016/06/06 at 09:01, Xunlei Pang wrote:
>>> On 2016/06/02 at 16:48, Dave Young wrote:
>>>> On 06/02/16 at 04:21pm, Xunlei Pang wrote:
>>>>> On 2016/06/02 at 15:46, Dave Young wrote:
>>>>>> Hi, Xunlei
>>>>>>
>>>>>> Seems I sent wrong draft, here is the right one:
>>>>>>
>>>>>> Add a question about below
>>>>>> --add-driver "nfs nfsv4"
>>>>>>
>>>>>> Why should we add them? if we addes dracut 95nfs module then it
will install
>>>>>> all the nfs kernel modules and network module.
>>>>> Yeah, dracut 95nfs module has
>>>>> installkernel() {
>>>>> instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
nfs_layout_nfsv41_files
>>>>> }
>>>>>
>>>>> But actually during my test, I found that if nfs was not mounted,
some of the modules
>>>>> (for example nfsv4)will fail to be installed by instmods.
>>>> Hmm, it may related to we use hostonly, could you check the instmods
function
>>>> to see if we can handle it without adding drivers in dracut args?
>>> You're right, it's due to the hostonly dracut option, and it's
not nfs-only, it's a common
>>> issue due to the target not mounted beforehand.
>>>
>>> Currently, I can't think of a nice way to handle it without adding
drivers explicitly.
>> I did some tests, seems dracut will parse "--mount" to add
filesystem-related ko modules.
>>
>> For nfs,
>> 1) if we specify "dracut_args --mount "10.66.129.115:/export/nfs /test
nfs defaults",
>> then "nfs.ko" will be added to initramfs only.
>> 2) if we specify "dracut_args --mount "10.66.129.115:/export/nfs /test
nfsv4 defaults",
>> then both "nfs.ko" and "nfsv4.ko" will be added.
> Further investigation shows that this can't work, the reason why nfsv4.ko is
added is because
> in 90kernel-modules/module-setup.sh installkernel(), we have:
> for i in $(host_fs_all); do
> hostonly='' instmods $i
> done
>
> So nfsv4.ko which is got from the fstype is added, but actually the mount will fail
due to the invalid
> "nfsv4" specified in "--mount"(the right one should be
"nfs4").
Seems we are still not clear about the problem, shouldn't it been mapped from
nfs4 -> nfsv4.ko automaticlly?
Unfortunately, the current implementation does no mapping about this.
Maybe we could throw a patch on this to let "nfs4" mapping to "nfsv4"
for
instmods.
Regards,
Xunlei
Also mount_needs should add kernel modules without considering
hostonly or not,
if --mount need instmods should install the ko unconditionally
> Regards,
> Xunlei
>
>> Regards,
>> Xunlei
>>
>>> Regards,
>>> Xunlei
>>>
>>>>>> But I have a concern, if the network can be setup correctly.
Kdump still will
>>>>>> find the right nic and set it up?
>>>>> The implementation patch added:
>>>>> + dracut_args)
>>>>> + if is_nfs_in_dracut_args "$config_val"; then
>>>>> + kdump_install_net "$(get_dracut_args_target
"$config_val")"
>>>>> + fi
>>>>> + ;;
>>>>>
>>>>> So the net device when specifying nfs can be installed correctly.
>>>>>
>>>> Ok, cool then it should be ok.
>>>>
>>>> BTW, for patch 1 I have not got time to think about it, maybe I will
reply
>>>> tomorrow.
>>>>
>>>> Thanks
>>>> Dave
> _______________________________________________
> kexec mailing list
> kexec(a)lists.fedoraproject.org
>
https://lists.fedoraproject.org/admin/lists/kexec@lists.fedoraproject.org
>
>