Dracut has "--hostonly-cmdline" which can generate cmdlines(if any) regarding the dump target, it's an existing way for us to use to simplify the code. E.g. We can remove generate_lvm_cmdlines() if we use "--hostonly-cmdline"(see PATCH 4).
But "--hostonly-cmdline" has other issues(e.g. BZ1451717), it adds needless devices for kdump like root device. These issues can be solved with the help of dracut "--no-hostonly-default-device", we can have only one device being recognized (dump target) in most cases under kdump.
This patch series applies dracut's "--hostonly-cmdline" together with "--no-hostonly-default-device", and removes some old code accordingly.
Please "man dracut.cmdline" for "--hostonly-cmdline", "--no-hostonly-default-device" details.
See "--no-hostonly-default-device" patches: https://github.com/dracutdevs/dracut/pull/269
Also see the following former threads for some background: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/...
Has passed tests about LUKS, iscsi, lvm, nfs, etc.
Xunlei Pang (9): Revert "mkdumprd: omit dracut modules in case of network dumping" Revert "mkdumprd: omit dracut modules in case of no dm target" Revert "mkdumprd: omit crypt when there is no crypt kdump target" Revert "kdumpctl: use generated rd.lvm.lv=X" kdumpctl: move is_fadump_capable() to kdump-lib.sh Change dump_to_rootfs to use "--mount" instead of "root=X" mkdumprd: apply dracut "--hostonly-cmdline" and "--no-hostonly-default-device" kdumpctl: remove some cmdline inheritage from 1st kernel module-setup: remove software iscsi cmdline generated by dracut
dracut-module-setup.sh | 5 +++++ kdump-lib.sh | 30 +++++++++---------------- kdumpctl | 61 ++++++++------------------------------------------ kexec-tools.spec | 2 +- mkdumprd | 61 +++++++------------------------------------------- 5 files changed, 34 insertions(+), 125 deletions(-)