Dave, Lianbo,
Thank you for your comments.
On 1/11/2019 3:43 AM, Dave Young wrote:
>> Use a convention like 'failsafe_action' then instead
of 'final_action'
>> which is confusing when used in conjunction with 'default_action'.
>
> I also think the current terms are confusing and something like
> 'success_action' and 'failure_action' might be more intuitive.
>
> So an idea I thought of is adding 'failure_action' as an alias of
> 'default' and removing 'default' in the future.
>
> failure_action <reboot | halt | poweroff | shell | dump_to_rootfs>
> default <reboot | halt | poweroff | shell | dump_to_rootfs>
> - Action to perform in case dumping fails.
> No difference between "failure_action" and
"default"
> but "default" directive will be removed in the future.
Sounds good, also should check these two can not coexist in kdump.conf
OK, I'll add the check to the next patch.
>
> success_action <reboot | halt | poweroff>
> - Action to perform in case dumping succeeds.
succes_action is not very accurate, in case kdump failed "default"
action runs, and after that final action still get change to run.
So final_action seems better.
OK, will leave final_action as it is.
Thanks,
Kazu