Acked-by: Tao Liu <ltao(a)redhat.com>
On Mon, Nov 01, 2021 at 02:25:14PM +0800, Coiby Xu wrote:
When there more than one binaries, quoting "$val" would
make
dracut-install treat multiple binaries as one binary. Take
"extra_bins /usr/sbin/ping /usr/sbin/ip" as an example, the
following error would occur when building initrd,
dracut-install: ERROR: installing '/usr/sbin/ping /usr/sbin/ip'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /var/tmp/dracut.ODrioZ/initramfs -a
/usr/sbin/ping /usr/sbin/ip
Fix it by not quoting the variable and bypassing SC2086 shellcheck.
Fixes: commit 86538ca6e2e555caa8cdd2bcfcc3c5e94ac6bf58
("bash scripts: fix variable quoting issue")
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
dracut-module-setup.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index a5e4b67..1ea0d95 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -686,7 +686,8 @@ kdump_install_conf() {
fi
;;
kdump_pre | kdump_post | extra_bins)
- dracut_install "$_val"
+ # shellcheck disable=SC2086
+ dracut_install $_val
;;
core_collector)
dracut_install "${_val%%[[:blank:]]*}"
--
2.31.1
_______________________________________________
kexec mailing list -- kexec(a)lists.fedoraproject.org
To unsubscribe send an email to kexec-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure