Hi Hari, Thanks for the update.
On Fri, Feb 1, 2019 at 6:26 PM Hari Bathini <hbathini(a)linux.ibm.com> wrote:
With kernel commit 0823c68b054b ("powerpc/fadump: re-register firmware-
assisted dump if already registered") support is enabled to re-register
when FADump is alredy registered. Leverage that option in kdump scripts.
Signed-off-by: Hari Bathini <hbathini(a)linux.ibm.com>
---
kdumpctl | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/kdumpctl b/kdumpctl
index de6da39..7b8013c 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -1047,7 +1047,8 @@ reload()
fi
if [ $DEFAULT_DUMP_MODE == "fadump" ]; then
- stop_fadump
+ reload_fadump
+ return $?
else
stop_kdump
fi
@@ -1103,6 +1104,22 @@ stop_kdump()
return 0
}
+reload_fadump()
+{
+ echo 1 > $FADUMP_REGISTER_SYS_NODE
+ if [ $? == 0 ]; then
+ echo "fadump: re-registered successfully"
+ return 0
+ else
+ # FADump could fail on older kernel where re-register
+ # support is not enabled. Try stop/start from userspace
+ # to handle such scenario.
+ stop_fadump
+ start_fadump
stop_fadump and start_fadump may also fail ), if stop_fadump failed
start_fadump should not be called or else it will wrongly report
"registered successfully". Would it be better to let reload_fadump
return right after try to re-register and don't try to fallback to
stop/start? Then callee would try to call reload_fadump() first, if
successed it return, else fail back to ordinary routine.
+ return $?
+ fi
+}
+
--
Best Regards,
Kairui Song