On Wed, Oct 26, 2022 at 01:52:42PM +0200, Philipp Rudo wrote:
Hi Coiby,
On Wed, 26 Oct 2022 14:20:43 +0800
Coiby Xu <coxu(a)redhat.com> wrote:
> Currently, updating kexec-tools gives the warning
^
maybe add a "on s390x" here
Applied, thanks for the suggestion and code review!
other than that
Reviewed-by: Philipp Rudo <prudo(a)redhat.com>
In my opinion you don't need to sent a v3 for that. Just update
the commit message and push it. Unless someone else has a complaint of
course.
Thanks
Philipp
> sed: can't read /etc/default/grub: No such file or directory
>
> This happens because s390x doesn't use GRUB and /etc/default/grub
> doesn't exist. We need to skip both reading and writing to
> /etc/default/grub.
>
> Reported-by: Jie Li <jieli(a)redhat.com>
>
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
> ---
> kdumpctl | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index 7f82f4fa..9961053e 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -1616,6 +1616,10 @@ update_crashkernel_in_grub_etc_default_after_update()
> return
> fi
>
> + if [[ $(uname -m) == s390x ]]; then
> + return
> + fi
> +
> _crashkernel=$(_read_kernel_arg_in_grub_etc_default crashkernel)
>
> if [[ -z $_crashkernel ]]; then
--
Best regards,
Coiby