6:58 p.m.
On Wed, Dec 29, 2021 at 09:36:52PM +0800, Pingfan Liu wrote:
On Tue, Dec 28, 2021 at 08:49:22AM +0800, Coiby Xu wrote:
> Add a helper function to get dump mode. The dump mode would be
> - fadump if fadump=on or fadump=nocma
> - kdump if fadump=off or empty fadump
>
> Otherwise return 1.
>
> Also add another helper function to return a kernel's dump mode.
>
> Signed-off-by: Coiby Xu <coxu(a)redhat.com>
> ---
> kdumpctl | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index f4ff457a..7eb8e9d3 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -1317,6 +1317,40 @@ get_grub_kernel_boot_parameter()
> grubby --info="$_kernel_path" | sed -En -e
"/^args=.*$/{s/^.*(\s|\")${_para}=(\S*).*\"$/\2/p;q}"
> }
>
> +# get dump mode by fadump value
> +# return
> +# - fadump, if fadump=on or fadump=nocma
> +# - kdump, if fadump=off or empty fadump, return kdump
> +# - error if otherwise
> +get_dump_mode_by_fadump_val()
> +{
> + local _fadump_val=$1
> +
> + if [[ -z $_fadump_val ]] || [[ $_fadump_val == off ]]; then
> + echo -n kdump
^^^ Any coding style about quotation mark around string?
I have no strong opinion about it, just wonder about it.
> + elif [[ $_fadump_val == on ]] || [[ $_fadump_val == nocma ]]; then
> + echo -n fadump
^^^ And here.
Thanks for raising this question. I'll start another thread or post a
patch about coding style to collect the feedback after I learn more
about .editorconfig (one issue I notice is it conflicts with the format of
git commit message. I'm not sure if it's caused by the vim plugin
editorconfig/editorconfig-vim or .editorconfig itself).
Else
Reviewed-by: Pingfan Liu <piliu(a)redhat.com>
Thanks for reviewing the patch!
> + else
> + derror "invalid fadump=$_fadump_val"
> + return 1
> + fi
> +}
> +
> +# get dump mode of a specific kernel
> +# based on its fadump kernel cmdline parameter
> +get_dump_mode_by_kernel()
> +{
> + local _kernel_path=$1 _fadump_val _dump_mode
> +
> + _fadump_val=$(get_grub_kernel_boot_parameter "$_kernel_path" fadump)
> + if _dump_mode=$(get_dump_mode_by_fadump_val "$_fadump_val"); then
> + echo -n "$_dump_mode"
> + else
> + derror "failed to get dump mode for kernel $_kernel_path"
> + exit
> + fi
> +}
> +
> reset_crashkernel()
> {
> local kernel=$1 entry crashkernel_default
> --
> 2.31.1
>
--
Best regards,
Coiby