-----Original Message-----
From: piliu <piliu(a)redhat.com>
Sent: Monday, June 1, 2020 11:28 AM
To: Onitsuka, Shinichi/鬼束 伸一 <onitsuka.shinic(a)fujitsu.com>;
kexec(a)lists.fedoraproject.org
Subject: Re: [PATCH v3 0/4] /etc/kdump/{pre.d,post.d} interface to set up multiple binary
and script files
Except comment for 1/4, I am OK with this series.
But please rebase them to the latest Fedora. It will ease maintainers'
work (although I am not). During my test, I found it far lagged behind
the repo, and I had to apply them by manual.
Thank you for your advice.
I recreated the patches based on newer commit(8fcbb4d265f6f7948081ecd88cccbb1d6548c449).
Thanks,
Pingfan
On 05/28/2020 08:17 AM, onitsuka.shinic(a)fujitsu.com wrote:
> There is restriction on kdump_pre and kdump_post directives now that can be
> specified only once in /etc/kdump.conf.
> However, there are multiple components that need to use the directives.
>
> This patch implements /etc/kdump/{pre.d,post.d} interface to set up multiple
> binary and script files.
>
> For example, users put multiple binary and script files under
> /etc/kdump/pre.d directory as below:
>
> # find /etc/kdump/pre.d
> /etc/kdump/pre.d/50-foo.sh
> /etc/kdump/pre.d/75-hoge.sh
>
> Then, 50-foo.sh and 75-hoge.sh are executed in order before kdump dump process
> begins just like kdump_pre directive written in /etc/kdump.conf.
>
> This is composed of the following three patches created based on
> commit 4b43ba063ddbcdccf95d761d2a3641f3006d814d.
>
> Signed-off-by: Shinichi Onitsuka <onitsuka.shinic(a)fujitsu.com>
>
> ---
> Changes since v1:
> [1]Change title.
> [2]Change behavior of non 0 Exit status that script/binary in kdump/pre.d was
returned.
> [3]Stop using find/sort commands.
> [4]Add checking execution bit.
> [5]Add specification of /etc/kdump/{pre.d,post.d} interface
>
> Changes since v2:
> [1]Correct sentence errors in kdump.conf.
> [2]Move the doc commit after the code change.
> [3]Change the name of the added function in dracut-module-setup.sh.
> [4]Change the commit comment of kdumpctl
> ---
>
> Shin-ichi Onitsuka (4):
> dracut-module-setup.sh: Install files under /etc/kdump/{pre.d,post.d}
> into kdump initramfs
> kdumpctl: Check the update of the binary and script files in
> /etc/kdump/{pre.d,post.d}
> dracut-kdump.sh: Execute the binary and script files in
> /etc/kdump/{pre.d,post.d}
> kdump.conf: Specify /etc/kdump/{pre.d,post.d} interface
>
> dracut-kdump.sh | 34 ++++++++++++++++++++++++++++++++++
> dracut-module-setup.sh | 25 +++++++++++++++++++++++++
> kdump.conf | 14 ++++++++++++--
> kdumpctl | 16 +++++++++++++++-
> 4 files changed, 86 insertions(+), 3 deletions(-)
>
Best Regards,
Shinichi Onitsuka