On 07/07/21 at 02:20pm, Kairui Song wrote:
In RHEL, kernel supports a `crashkernel=auto` param and when it's
used,
kernel will use its built-in default value as the crashkernel value.
But upstream doesn't like this idea. [1]
`crashkernel=auto` was introduced to provide user a default value, and
make it possible to update the crashkernel value automatically as kernel
package updates if user is using the default `auto` value.
After more discussion, `crashkernel=auto` will be dropped. To track
the default crashkernel value, kernel package will include a
crashkernel.default file with it[2], and kexec-tools can make use of
that file, update kernel's boot cmdline accordingly, and help user to
reset the crashkernel value to default value.
The patchset looks good to me, ack. Thanks for the effort.
Acked-by: Baoquan He <bhe(a)redhat.com>
Thanks
Baoquan
[1]:
https://lore.kernel.org/linux-mm/20210507010432.IN24PudKT%25akpm@linux-fo...
[2]:
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1171
Update from V2:
- Update the doc as suggested by Baoquan
- Fix some comment and code issues in 92-crashkernel.install
Update from V1:
- Add support for ostree
- Add a crashkernel-howto.txt
- Change crashkernel.conf to crashkernel.default
Kairui Song (4):
Revert "kdump-lib.sh: Remove is_atomic"
kdumpctl: Add kdumpctl reset-crashkernel
Add a new hook: 92-crashkernel.install
Add a crashkernel-howto.conf doc
92-crashkernel.install | 143 +++++++++++++++++++++++++++++
crashkernel-howto.conf | 204 +++++++++++++++++++++++++++++++++++++++++
kdump-lib.sh | 5 +
kdumpctl | 41 ++++++++-
kdumpctl.8 | 9 ++
kexec-tools.spec | 7 ++
6 files changed, 407 insertions(+), 2 deletions(-)
create mode 100755 92-crashkernel.install
create mode 100644 crashkernel-howto.conf
--
2.31.1