On 07/31/14 at 11:31am, WANG Chao wrote:
On 07/31/14 at 10:41am, Dave Young wrote:
> On 07/29/14 at 09:41am, Vivek Goyal wrote:
> > On Tue, Jul 29, 2014 at 08:57:55PM +0800, WANG Chao wrote:
> > > Now upon failure kdump script might not be called at all and it might
> > > not be able to execute default action. It results in a hang.
> > >
> > > Because we disable emergency shell and rely on kdump.sh being invoked
> > > through dracut-pre-pivot hook. But it might happen that we never call
> > > into dracut-pre-pivot hook because certain systemd targets could not
> > > reach due to failure in their dependencies. In those cases error
> > > handling code does not run and system hangs.
> > I think it is important to show the systemd dependency graph here.
> > Just couple of lines.
> > xyz--->foo.target---->bar.service--->dracut-pre-pivot
> > And show what target does not reach hence mention that dracut-pre-pivot
> > hook does not run.
> It will be even better to add the graph to the service file as comment.
> Maybe copy some description from patch description to service file as well.
I think Vivek meant for demostrating why dracut-pre-pivot doesn't work.
Putting the cause down in the service file doesn't make sense..
Hmm, not specific to the graph. For the service itself, add some background and
documentation to the service file will make it clear to anyone. So we can avoid
to search in git log.