[PATCH 00/12] Refactor RecipeCommon.Ping

This is a series of patches that attempts to remove the duplicated code in Recipes/ENRT in case of cross-vlan ping runs. The changes include: * split of ping command execution and evaluation of results * introducing two basic Ping evaluators * replacing the duplicated code in Recipes/ENRT with the new reusable code Jan Tluka (12): RecipeCommon.Ping: rename running_ping to ping RecipeCommon.Ping: move prepare_job to ping_init RecipeCommon.Ping: remove ping_config from ping_evaluate_and_report Tests.Ping: update failure logic Tests.Ping: do not check rtt data if no packets were received RecipeCommon.Ping: rename ping_evaluate_and_report method lnst.RecipeCommon: move Ping Recipe to separate directory lnst.RecipeCommon.Ping: add Ping evaluators RecipeCommon.Ping.Recipe: add evaluators to PingConf object Recipes.ENRT.BaseEnrtRecipe: register default PingEvaluator RecipeCommon.Ping.Recipe: split report and evaluate Recipes.ENRT: use Ping evaluators to remove code duplicity .../Ping/Evaluators/RatePingEvaluator.py | 59 +++++++++++++++++++ .../Ping/Evaluators/ZeroPassPingEvaluator.py | 22 +++++++ lnst/RecipeCommon/Ping/Evaluators/__init__.py | 2 + lnst/RecipeCommon/{Ping.py => Ping/Recipe.py} | 51 ++++++++++------ lnst/RecipeCommon/Ping/__init__.py | 0 lnst/Recipes/ENRT/BaseEnrtRecipe.py | 8 ++- lnst/Recipes/ENRT/BasePvPRecipe.py | 2 +- lnst/Recipes/ENRT/IpsecEspAeadRecipe.py | 2 +- lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py | 2 +- lnst/Recipes/ENRT/OvS_DPDK_PvP.py | 2 +- lnst/Recipes/ENRT/PingFloodRecipe.py | 4 +- lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py | 46 +++------------ .../ENRT/VirtualBridgeVlansOverBondRecipe.py | 49 +++------------ .../VirtualOvsBridgeVlansOverBondRecipe.py | 49 +++------------ lnst/Recipes/ENRT/VlansOverBondRecipe.py | 49 +++------------ lnst/Recipes/ENRT/VlansOverTeamRecipe.py | 49 +++------------ lnst/Recipes/ENRT/VlansRecipe.py | 49 +++------------ lnst/Tests/Ping.py | 20 +++---- 18 files changed, 189 insertions(+), 276 deletions(-) create mode 100644 lnst/RecipeCommon/Ping/Evaluators/RatePingEvaluator.py create mode 100644 lnst/RecipeCommon/Ping/Evaluators/ZeroPassPingEvaluator.py create mode 100644 lnst/RecipeCommon/Ping/Evaluators/__init__.py rename lnst/RecipeCommon/{Ping.py => Ping/Recipe.py} (65%) create mode 100644 lnst/RecipeCommon/Ping/__init__.py -- 2.21.1