On Wed, Aug 19, 2015 at 08:58:34AM +0200, Jiri Pirko wrote:
Wed, Aug 19, 2015 at 08:42:42AM CEST, jprochaz(a)redhat.com wrote:
>Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
>---
> recipes/examples/netem/netem_test.py | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/recipes/examples/netem/netem_test.py
b/recipes/examples/netem/netem_test.py
>index 2405f11..af8c110 100644
>--- a/recipes/examples/netem/netem_test.py
>+++ b/recipes/examples/netem/netem_test.py
>@@ -6,9 +6,12 @@ hostB = ctl.get_host("machine2")
> hostA.sync_resources(modules=["IcmpPing", "Netperf"])
> hostB.sync_resources(modules=["IcmpPing", "Netperf"])
>
>+hostA_testiface = hostA.get_interface("testiface")
>+hostB_testiface = hostB.get_interface("testiface")
>+
> ping_mod = ctl.get_module("IcmpPing",
> options={
>- "addr": hostB.get_ip("testiface", 0),
>+ "addr": hostB_testiface.get_ip_addr(0),
I wonder, why this is "get_ip_addr" and not just "get_ip". Seems
inconsistent. Could we rename this (perhaps leaving "get_ip_addr" alias) ?
I think my original idea was that get_ip_addr and get_ip_addrs looked
better than get_ip and get_ips. However now that I'm looking at it I'm
ok with renaming them/adding a new alias.
-Ondrej