[Bug 523224] Review Request: mingw32-xerces-c - MingGW Windows validating XML parser
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=523224
Kalev Lember <kalev(a)smartlink.ee> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kalev(a)smartlink.ee
AssignedTo|nobody(a)fedoraproject.org |kalev(a)smartlink.ee
Flag| |fedora-review+
--- Comment #1 from Kalev Lember <kalev(a)smartlink.ee> 2009-11-24 13:08:29 EDT ---
Fedora review mingw32-xerces-c-3.0.1-1.fc12.src.rpm 2009-11-24
+ OK
! needs attention
rpmlint says:
mingw32-xerces-c.src: W: spelling-error-in-description en_US Namespaces
mingw32-xerces-c.noarch: W: spelling-error-in-description en_US Namespaces
mingw32-xerces-c-debuginfo.noarch: W: spelling-error-in-summary en_US mingw
mingw32-xerces-c-debuginfo.noarch: W: spelling-error-in-description en_US mingw
mingw32-xerces-c-debuginfo.noarch: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 4 warnings.
All these rpmlint warnings are harmless and can be ignored. The
debuginfo-without-sources doesn't mean that anything is wrong with this
package, but rather that mingw32 debug package generator doesn't put sources in
the package.
+ rpmlint output
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ The stated license (ASL 2.0) is a Fedora approved license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (LICENSE)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. sha1sum:
71e4efee5397dd45d6bafad34bf3bc766bc2a085 xerces-c-3.0.1.tar.gz
71e4efee5397dd45d6bafad34bf3bc766bc2a085 Download/xerces-c-3.0.1.tar.gz
+ Package builds in mock/koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
+ Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
Looks good. APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
[Bug 537897] Review Request: mingw32-openjpeg - mingw32 package for openjpeg
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537897
Peter Lemenkov <lemenkov(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lemenkov(a)gmail.com
--- Comment #2 from Peter Lemenkov <lemenkov(a)gmail.com> 2009-11-24 09:33:42 EDT ---
(In reply to comment #1)
> BTW, shouldn't the file ChangeLog be included as %doc?
In many cases - not necessary. The ChangeLog is always too exhaustive for the
average users (our intended auditory) - very often it contains descriptions of
almost every commit, so NEWS file with more simplified history would be far
more valuable.
> hope this helps,
> Stefan
Yes, indeed! You almost finished the Review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
14 years, 5 months
rpms/mingw32-gcc/devel gcc44-ppc64-aixdesc.patch, NONE, 1.1 .cvsignore, 1.6, 1.7 gcc44-hack.patch, 1.2, 1.3 gcc44-pr38757.patch, 1.1, 1.2 mingw32-gcc.spec, 1.9, 1.10 sources, 1.6, 1.7 gcc44-raw-string.patch, 1.2, NONE gcc44-rh503816-1.patch, 1.1, NONE gcc44-rh503816-2.patch, 1.1, NONE
by Kalev Lember
Author: kalev
Update of /cvs/pkgs/rpms/mingw32-gcc/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv17986
Modified Files:
.cvsignore gcc44-hack.patch gcc44-pr38757.patch
mingw32-gcc.spec sources
Added Files:
gcc44-ppc64-aixdesc.patch
Removed Files:
gcc44-raw-string.patch gcc44-rh503816-1.patch
gcc44-rh503816-2.patch
Log Message:
4.4.2-1
gcc44-ppc64-aixdesc.patch:
sysv4.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- NEW FILE gcc44-ppc64-aixdesc.patch ---
2009-09-16 Jakub Jelinek <jakub(a)redhat.com>
* config/rs6000/sysv4.h (FP_SAVE_INLINE, GP_SAVE_INLINE): Disable
out of line gpr/fpr saving for -m64 -Os -mcall-aixdesc.
--- gcc/config/rs6000/sysv4.h.jj 2009-09-16 14:46:19.000000000 +0200
+++ gcc/config/rs6000/sysv4.h 2009-09-16 14:46:19.000000000 +0200
@@ -273,12 +273,14 @@ do { \
/* Define cutoff for using external functions to save floating point.
When optimizing for size, use external functions when profitable. */
#define FP_SAVE_INLINE(FIRST_REG) (optimize_size \
+ && (!TARGET_64BIT || !DOT_SYMBOLS) \
? ((FIRST_REG) == 62 \
|| (FIRST_REG) == 63) \
: (FIRST_REG) < 64)
/* And similarly for general purpose registers. */
-#define GP_SAVE_INLINE(FIRST_REG) ((FIRST_REG) < 32 \
- && !optimize_size)
+#define GP_SAVE_INLINE(FIRST_REG) ((FIRST_REG) < 32 \
+ && (!optimize_size \
+ || (TARGET_64BIT && DOT_SYMBOLS)))
/* Put jump tables in read-only memory, rather than in .text. */
#define JUMP_TABLES_IN_TEXT_SECTION 0
Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-gcc/devel/.cvsignore,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- .cvsignore 3 Sep 2009 21:30:42 -0000 1.6
+++ .cvsignore 22 Nov 2009 22:13:03 -0000 1.7
@@ -1 +1 @@
-gcc-4.4.1-20090902.tar.bz2
+gcc-4.4.2-20091114.tar.bz2
gcc44-hack.patch:
gcc/ada/make.adb | 1 +
libada/Makefile.in | 32 +++++++++++++++++++++++++++-----
2 files changed, 28 insertions(+), 5 deletions(-)
Index: gcc44-hack.patch
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-gcc/devel/gcc44-hack.patch,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -p -r1.2 -r1.3
--- gcc44-hack.patch 25 Aug 2009 20:26:27 -0000 1.2
+++ gcc44-hack.patch 22 Nov 2009 22:13:04 -0000 1.3
@@ -1,6 +1,6 @@
--- libada/Makefile.in.jj 2009-01-14 12:07:35.000000000 +0100
+++ libada/Makefile.in 2009-01-15 14:25:33.000000000 +0100
-@@ -67,17 +67,39 @@ version := $(shell cat $(srcdir)/../gcc/
+@@ -69,18 +69,40 @@ version := $(shell cat $(srcdir)/../gcc/
libsubdir := $(libdir)/gcc/$(target_noncanonical)/$(version)$(MULTISUBDIR)
ADA_RTS_DIR=$(GCC_DIR)/ada/rts$(subst /,_,$(MULTISUBDIR))
@@ -38,12 +38,14 @@
"SHELL=$(SHELL)" \
- "GNATLIBFLAGS=$(GNATLIBFLAGS) $(MULTIFLAGS)" \
- "GNATLIBCFLAGS=$(GNATLIBCFLAGS) $(MULTIFLAGS)" \
+- "GNATLIBCFLAGS_FOR_C=$(GNATLIBCFLAGS_FOR_C) $(MULTIFLAGS)" \
+ "GNATLIBFLAGS=$(strip $(GNATLIBFLAGS) $(MULTIFLAGS) $(DEFAULTMULTIFLAGS))" \
+ "GNATLIBCFLAGS=$(strip $(GNATLIBCFLAGS) $(MULTIFLAGS) $(DEFAULTMULTIFLAGS))" \
++ "GNATLIBCFLAGS_FOR_C=$(strip $(GNATLIBCFLAGS_FOR_C) $(MULTIFLAGS) $(DEFAULTMULTIFLAGS))" \
"TARGET_LIBGCC2_CFLAGS=$(TARGET_LIBGCC2_CFLAGS)" \
"THREAD_KIND=$(THREAD_KIND)" \
"TRACE=$(TRACE)" \
-@@ -88,7 +110,7 @@ LIBADA_FLAGS_TO_PASS = \
+@@ -91,7 +113,7 @@ LIBADA_FLAGS_TO_PASS = \
"exeext=.exeext.should.not.be.used " \
'CC=the.host.compiler.should.not.be.needed' \
"GCC_FOR_TARGET=$(CC)" \
gcc44-pr38757.patch:
c-lang.c | 10 +++++++++-
dwarf2out.c | 19 ++++++++++++++++---
langhooks-def.h | 4 +++-
langhooks.h | 6 +++++-
4 files changed, 33 insertions(+), 6 deletions(-)
Index: gcc44-pr38757.patch
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-gcc/devel/gcc44-pr38757.patch,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -p -r1.1 -r1.2
--- gcc44-pr38757.patch 23 Mar 2009 10:56:41 -0000 1.1
+++ gcc44-pr38757.patch 22 Nov 2009 22:13:04 -0000 1.2
@@ -90,7 +90,7 @@
const struct lang_hooks lang_hooks = LANG_HOOKS_INITIALIZER;
--- gcc/dwarf2out.c.jj 2009-03-17 13:06:29.000000000 +0100
+++ gcc/dwarf2out.c 2009-03-18 12:55:36.000000000 +0100
-@@ -12470,9 +12470,18 @@ add_bit_size_attribute (dw_die_ref die,
+@@ -14286,9 +14286,18 @@ add_bit_size_attribute (dw_die_ref die,
static inline void
add_prototyped_attribute (dw_die_ref die, tree func_type)
{
@@ -112,18 +112,14 @@
}
/* Add an 'abstract_origin' attribute below a given DIE. The DIE is found
-@@ -14419,7 +14428,13 @@ gen_compile_unit_die (const char *filena
- else if (strcmp (language_string, "GNU Objective-C++") == 0)
- language = DW_LANG_ObjC_plus_plus;
- else
-- language = DW_LANG_C89;
-+ {
-+ if (lang_hooks.source_language
-+ && lang_hooks.source_language () >= 1999)
+@@ -16290,6 +16299,10 @@ gen_compile_unit_die (const char *filena
+ language = DW_LANG_ObjC;
+ else if (strcmp (language_string, "GNU Objective-C++") == 0)
+ language = DW_LANG_ObjC_plus_plus;
++ else if (strcmp (language_string, "GNU C") == 0
++ && lang_hooks.source_language
++ && lang_hooks.source_language () >= 1999)
+ language = DW_LANG_C99;
-+ else
-+ language = DW_LANG_C89;
-+ }
+ }
add_AT_unsigned (die, DW_AT_language, language);
- return die;
Index: mingw32-gcc.spec
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-gcc/devel/mingw32-gcc.spec,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -p -r1.9 -r1.10
--- mingw32-gcc.spec 17 Sep 2009 23:18:04 -0000 1.9
+++ mingw32-gcc.spec 22 Nov 2009 22:13:04 -0000 1.10
@@ -1,11 +1,11 @@
%global __os_install_post /usr/lib/rpm/brp-compress %{nil}
-%global DATE 20090902
-%global SVNREV 151328
+%global DATE 20091114
+%global SVNREV 154179
Name: mingw32-gcc
-Version: 4.4.1
-Release: 3%{?dist}
+Version: 4.4.2
+Release: 1%{?dist}
Summary: MinGW Windows cross-compiler (GCC) for C
License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ with exceptions
@@ -34,12 +34,10 @@ Patch11: gcc44-sparc-config-detec
Patch12: gcc44-libgomp-omp_h-multilib.patch
Patch13: gcc44-libtool-no-rpath.patch
Patch14: gcc44-cloog-dl.patch
-Patch15: gcc44-raw-string.patch
Patch16: gcc44-unwind-debug-hook.patch
Patch17: gcc44-pr38757.patch
Patch18: gcc44-libstdc++-docs.patch
-Patch19: gcc44-rh503816-1.patch
-Patch20: gcc44-rh503816-2.patch
+Patch19: gcc44-ppc64-aixdesc.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -134,14 +132,12 @@ MinGW Windows cross-compiler for FORTRAN
%patch12 -p0 -b .libgomp-omp_h-multilib~
%patch13 -p0 -b .libtool-no-rpath~
%patch14 -p0 -b .cloog-dl~
-%patch15 -p0 -b .raw-string~
%patch16 -p0 -b .unwind-debug-hook~
%patch17 -p0 -b .pr38757~
%patch18 -p0 -b .libstdc++-docs~
-%patch19 -p0 -b .rh503816-1~
-%patch20 -p0 -b .rh503816-2~
+%patch19 -p0 -b .ppc64-aixdesc~
-sed -i -e 's/4\.4\.2/%{version}/' gcc/BASE-VER
+sed -i -e 's/4\.4\.3/%{version}/' gcc/BASE-VER
echo 'Fedora MinGW %{version}-%{release}' > gcc/DEV-PHASE
@@ -292,6 +288,11 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Sun Nov 22 2009 Kalev Lember <kalev(a)smartlink.ee> - 4.4.2-1
+- Update to gcc 4.4.2 20091114 svn 154179, which includes
+ VTA backport from 4.5 branch.
+- Patches taken from native Fedora gcc-4.4.2-10.
+
* Fri Sep 18 2009 Kalev Lember <kalev(a)smartlink.ee> - 4.4.1-3
- Require mingw32-binutils >= 2.19.51.0.14 for %%gnu_unique_object support.
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-gcc/devel/sources,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- sources 3 Sep 2009 21:30:43 -0000 1.6
+++ sources 22 Nov 2009 22:13:04 -0000 1.7
@@ -1 +1 @@
-eb2fb0d2c073de0b4edf78dab958aca4 gcc-4.4.1-20090902.tar.bz2
+bcc990c4eafa005e2e15db24e8745cd1 gcc-4.4.2-20091114.tar.bz2
--- gcc44-raw-string.patch DELETED ---
--- gcc44-rh503816-1.patch DELETED ---
--- gcc44-rh503816-2.patch DELETED ---
14 years, 5 months
Gecko and Wine issue
by Jason L Tibbitts III
I just wanted to let you folks know about a current discussion going on
between various Wine developers. Wine uses Gecko, the Mozilla rendering
engine, as a replacement for whatever is in Windows. Currently at issue
is how a user of Wine actually gets gecko on their system. It can be
downloaded at wine startup, which is problematic for various reasons, or the
distro can package it. But what's needed are the actual win32 gecko
libraries, not a native Linux version, which sort of involves
using mingw and cross-compiling.
The alternative of just sticking the cab in an rpm is obviously not
acceptable for Fedora.
The relevant thread starts at
http://www.winehq.org/pipermail/wine-devel/2009-November/079744.html
There's a wiki page http://wiki.winehq.org/Gecko which talks about
distros which package Gecok "properly", where that seems to be just
dropping a binary in the right place without any regard for how its
built or how that conflicts with a distro's goals and requirements,
although there is a complaint about this at
http://www.winehq.org/pipermail/wine-devel/2009-November/079819.html
There's also mention about mingw needing patching to handle building
gecko at
http://www.winehq.org/pipermail/wine-devel/2009-November/079851.html
Feel free to ignore me entirely; I just wanted to bring this to the
attention of folks who might understand things far better than I.
- J<
14 years, 5 months
rpms/mingw32-libpng/devel mingw32-libpng-fix-invalid-exports.patch, NONE, 1.1 mingw32-libpng.spec, 1.7, 1.8
by Erik van Pienbroek
Author: epienbro
Update of /cvs/pkgs/rpms/mingw32-libpng/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv15342
Modified Files:
mingw32-libpng.spec
Added Files:
mingw32-libpng-fix-invalid-exports.patch
Log Message:
* Fri Nov 20 2009 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 1.2.40-2
- In the previous build no symbols were exported in the resulting DLL making this
package unusable. This should be fixed for now (but may need more research)
mingw32-libpng-fix-invalid-exports.patch:
configure | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- NEW FILE mingw32-libpng-fix-invalid-exports.patch ---
--- configure.orig 2009-11-20 01:18:09.926590381 +0100
+++ configure 2009-11-20 01:18:37.352678377 +0100
@@ -11447,10 +11447,7 @@
if test "$have_ld_version_script" = "yes"; then
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for symbol prefix" >&5
$as_echo_n "checking for symbol prefix... " >&6; }
- SYMBOL_PREFIX=`echo "PREFIX=__USER_LABEL_PREFIX__" \
- | ${CPP-${CC-gcc} -E} - 2>&1 \
- | ${EGREP-grep} "^PREFIX=" \
- | ${SED-sed} "s:^PREFIX=::"`
+ SYMBOL_PREFIX=""
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $SYMBOL_PREFIX" >&5
$as_echo "$SYMBOL_PREFIX" >&6; }
Index: mingw32-libpng.spec
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-libpng/devel/mingw32-libpng.spec,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -p -r1.7 -r1.8
--- mingw32-libpng.spec 5 Nov 2009 11:34:39 -0000 1.7
+++ mingw32-libpng.spec 20 Nov 2009 00:58:22 -0000 1.8
@@ -6,7 +6,7 @@
Name: mingw32-libpng
Version: 1.2.40
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: MinGW Windows Libpng library
License: zlib
@@ -14,6 +14,7 @@ URL: http://www.libpng.org/pu
Source0: ftp://ftp.simplesystems.org/pub/png/src/libpng-%{version}.tar.bz2
Patch0: libpng-multilib.patch
Patch1: libpng-pngconf.patch
+Patch2: mingw32-libpng-fix-invalid-exports.patch
Group: Development/Libraries
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -36,6 +37,14 @@ MinGW Windows Libpng library.
%patch0 -p1
%patch1 -p1
+# The configure script tries to generate a prefix which is used for
+# symbol declarations. However, when this prefix is prefix is used
+# the resulting DLL's don't have any exported symbols at all
+# When we drop this prefix we retain backwards compatibility with
+# older versions of mingw32-libpng. We might need to research this
+# issue more to find out the real cause, but this will do for now
+%patch2 -p0
+
%build
%{_mingw32_configure}
@@ -78,6 +87,10 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Fri Nov 20 2009 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 1.2.40-2
+- In the previous build no symbols were exported in the resulting DLL making this
+ package unusable. This should be fixed for now (but may need more research)
+
* Thu Nov 5 2009 Richard W.M. Jones <rjones(a)redhat.com> - 1.2.40-1
- New upstream version 1.2.40.
14 years, 5 months
