Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=546998
--- Comment #12 from Chris Bagwell <chris(a)cnpbagwell.com> 2009-12-15 12:24:03 EDT
---
(In reply to comment #9)
I've got a few comments.
1) The subpackage which has libgomp-1.dll probably also needs to get manual
provides because the automatic dependency scripts aren't run:
Provides: mingw32(libgomp-1.dll)
Makes sense. But should it be the package name? I'll add once its confirmed.
Provides: mingw32-libgomp(libgomp-1.dll)
2) %{_libdir}/gcc/i686-pc-mingw32/%{version}/finclude/ directory looks unowned.
OK, will fix.
3) In native gcc package finclude/ is part of gfortran subpackage, and
include/omp.h is part of main gcc package. Why did you choose to include these
under mingw32-libgomp instead? (I'm not saying it's bad, just trying to explore
different options.)
This was a judgment call that I'll probably revert but would like opinions
first. Since libgomp has headers for C and fortran *and* is optional, some
choices have to be made on where to package them. Options: 1) Include both
types of headers with mingw32-gcc package which means you can see C header file
omp.h even when libgomp is not installed or fortran files when fortran compile
is not installed. 2) Include both of them in mingw32-libgomp which has nice
side affect that gcc won't see either header nor library when no libgomp
libraries installed but it can mean fortran headers installed without fortran
compiler. 3) Break into a mingw32-libgomp and mingw32-libgomp-fortran with
appropriate Requires.
gcc.spec chose #1 which I find strange in that my configure scripts have to
check for both header file omp.h and additionally do a -lgomp test to verify
its really supported; when often the short cut of just looking for header file
is enough. So I chose #2 to prevent gcc from seeing header file which I left
slightly better.
I already have to deal with issues from #1 because of i686-redhat-linux-gcc
compilers, so for consistency I should probably chose #1 for
i686-pc-mingw32-gcc. Agree?
4) Does the libgomp.spec which gets installed in
{_libdir}/gcc/i686-pc-mingw32/%{version}/ really belong in there?
Ignoring this item as requested in later response.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.