Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502689
Kalev Lember <kalev(a)smartlink.ee> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |kalev(a)smartlink.ee
Alias|cppunit |mingw32-cppunit
Flag| |fedora-review?
--- Comment #1 from Kalev Lember <kalev(a)smartlink.ee> 2009-08-02 13:15:06 EDT ---
Taking for review.
Some initial notes:
! Building the package fails in mock because of
missing BuildRequires mingw32-gcc-c++
! If doxygen is present in build host, building fails with:
error: Installed (but unpackaged) file(s) found:
/usr/i686-pc-mingw32/sys-root/mingw/share/doc/cppunit/FAQ
/usr/i686-pc-mingw32/sys-root/mingw/share/doc/cppunit/_additional_message_8cpp.html
/usr/i686-pc-mingw32/sys-root/mingw/share/doc/cppunit/_additional_message_8cpp__incl.map
<snip>
Please use explicit --disable-doxygen configure option to prevent that.
! cppunit-config.1 duplicates documentation of native cppunit package. As per
Fedora MinGW packaging guidelines[1], those man pages that are duplicates of
the ones found in native packages should be removed.
! rpmlint output:
$ rpmlint mingw32-cppunit-1.12.1-1.fc12.src.rpm
mingw32-cppunit-1.12.1-1.fc12.noarch.rpm
mingw32-cppunit.noarch: W: manpage-not-compressed-with-gzip
/usr/i686-pc-mingw32/sys-root/mingw/share/man/man1/cppunit-config.1
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
That warning will go away if you remove cppunit-config.1 man page as discussed
above.
! All DLLs in %files section should be listed separately as per Fedora MinGW
packaging guidelines
! Fedora Packaging Guidelines prefer %global macro instead of %define. [2]
! description says:
MinGW Windows cppunit compression library.
It's not really a compression library, is it?
Also consider changing description from:
C++ unit testing framework
to:
MinGW Windows C++ unit testing framework
to better match other Fedora MinGW packages.
[1]
http://fedoraproject.org/wiki/Packaging/MinGW
[2]
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_o...
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.