Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467418
Adam Stokes <astokes(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |needinfo?
--- Comment #14 from Adam Stokes <astokes(a)redhat.com> 2010-09-02 12:01:11 EDT ---
(In reply to comment #10)
MUST: If (and only if) the source package includes the text of the
license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
- fail
SHOULD: please include this in spec at some point
MUST: The package MUST successfully compile and build into binary
rpms on at
least one primary architecture. [7]
- pass
MUST: All build dependencies must be listed in BuildRequires, except
for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
-
pass
MUST: The spec file MUST handle locales properly. This is done by
using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
-
pass
MUST: A package must own all directories that it creates. If it does
not create
a directory that it uses, then it should require a package which does create
that directory. [13]
- pass
MUST: Permissions on files must be set properly. Executables should
be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
- pass
MUST: Packages must NOT contain any .la libtool archives, these must
be removed
in the spec if they are built.[20]
- fail
MUST: Packages must not own files or directories already owned by
other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no
- pass
MUST: All filenames in rpm packages must be valid UTF-8. [24]
- pass
SHOULD: The reviewer should test that the package builds in mock.
- pass
SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.
- pass
Everything looks great except for the packaged libvirt.la, once this is removed
I'll approve the package.
Thanks
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.