Re: [netcf-devel] [PATCH] report link state/speed in interface status

This patch adds reporting of link state and speed for appropriate types of interfaces. It is added to the interface status as a single element: <link state='up|down|whatever' speed='nn'/> (the speed is in Mbits/sec, i.e. exactly what is reported by the kernel). The information come from the following locations in sysfs: state - /sys/class/net/$ifname/operstate speed - /sys/class/net/$ifname/speed Note that speed will be set to 0 if operstate is anything but "up".

Also, this element is not added if an interface is of type "bridge" (although any interfaces attached to the bridge, and reported as subordinate interfaces in the same xml, *will* get a <link> element.) An example - this is a bridge device which has one bond attached; the bond is comprised of two ethernets: <interface name="br0" type="bridge"> <bridge> <interface name="bond0" type="bond"> <link state="up" speed="1000"/> <bond> <interface name="p13p2_5" type="ethernet"> <link state="up" speed="1000"/> <mac address="ea:8b:8d:18:67:fe"/> </interface> <interface name="p13p2_6" type="ethernet"> <link state="up" speed="1000"/>

(note that in this case the bond reports a speed of 1000, although in some cases I have seen it report "2000". This is an issue of the kernel driver - netcf merely reports whatever the kernel has said.)

+ if (!strcmp(state, "up")) { + /* When the link state is "down", different drivers report a + * different value for speed. In one local sample, the + * following were seen: "10", "65535", "4294967295". Since the + * effective speed is "0", just change it to that whenever the + * link state is not "up". + */

+ xasprintf(&path, "/sys/class/net/%s/speed", ifname); + ERR_NOMEM(path == NULL, ncf); + speed = read_file(path, &length); + if (!speed && errno == EINVAL) { + /* attempts to read $ifname/speed result in EINVAL if the + * interface is ifconfiged down (which isn't exactly the + * same as an operstate of "down"). + */ + speed = strdup("0"); + ERR_NOMEM(!speed, ncf); + } + ERR_THROW_STRERROR(!speed, ncf, EFILE, "Failed to read %s", path); + if ((nl = strchr(speed, '\n'))) + *nl = 0; + } else { + FREE(speed); + speed = strdup("0"); + ERR_NOMEM(!speed, ncf); + }

@@ -1061,6 +1129,7 @@ error: return; } + void add_state_to_xml_doc(struct netcf_if *nif, xmlDocPtr doc) {