Re: [netcf-devel] [PATCH 1/5] initial checkin to fix configure and automake/build stuffs on fbsd
The commit comment doesn't match what is done here. In this patch you're
just adding some stub files that aren't referenced anywhere in the build
yet. (My preference would be to add them, with proper stub content,
during the same patch that introduces them to the build.)
It really seems like this patch and 2/5 should just be combined.
On 05/18/2012 12:38 PM, Sean Bruno wrote:
---
src/drv_fbsd.c | 176 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/dutil_fbsd.c | 27 +++++++++
src/dutil_fbsd.h | 30 ++++++++++
You may see this as nitpicking, but I'd prefer the full name of the OS
rather than an abbreviation :-)
- /dev/null
+++ b/src/dutil_fbsd.c
@@ -0,0 +1,27 @@
+/*
+ * dutil_mswindows.c: Windows utility functions for driver backends.
+ *
+ * Copyright (C) 2010 Red Hat Inc.
You forgot to change the comments for proper filename, copyright, and
author.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Adam Stokes <astokes(a)fedoraproject.org>
+ */
+
+#include <config.h>
+#include <internal.h>
+
+#include "dutil.h"
+#include "dutil_mswindows.h"
wrong .h file too.
diff --git a/src/dutil_fbsd.h b/src/dutil_fbsd.h
new file mode 100644
index 0000000..78295b5
--- /dev/null
+++ b/src/dutil_fbsd.h
@@ -0,0 +1,30 @@
+/*
+ * dutil_mswindows.h: Window utility functions for driver backends.
+ *
+ * Copyright (C) 2010 Red Hat Inc.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Author: Adam Stokes <astokes(a)fedoraproject.org>
+ */
+
+#ifndef DUTIL_MSWINDOWS_H_
+#define DUTIL_MSWINDOWS_H_
same.
+
+struct driver {
+ int padding;
+};
+
+#endif /* DUTIL_MSWINDOWS_H_ */