On Wed, 2009-11-04 at 09:09 -0500, Cole Robinson wrote:
But assuming a config is more complex than that and has info that
can't
be rediscovered, not sure what the solution is. Maybe when undefining
wlan0, netcf can store a backup of the ifcfg somewhere for restoring it
when the bridge goes away.
What if wlan0 was enslaved to br1, and got reconfigured to be part of
br0 ? We can't just restore an old config silently. Applications can do
that, since they have a much better view of what is happening with
interfaces.
At the end of the day, I'm looking for the best way to avoid
future
virt-manager bug reports like:
- Help! I bridged eth1 in virt-manager, restarted the app, then deleted
the bridge and eth1 is no longer in my list of interfaces!
I think it all boils down to who should do device discovery. As I
understand it, what you want is for virt-manager to have a way to list
all physical interfaces on a machine, figure out which ones are not used
by any bridge/bond etc. and offer those for addition into a new bridge.
For the first bit, libvirt provides the virNodeDevice* calls; for
figuring out which devices are free, we'd need to add something to
netcf, e.g. new error codes to indicate 'interface has no configuration'
and 'interface is slave of another interface' when calling
ncf_lookup_by_name. Would something like that help virt-manager ?
David