openlmi-reviews September 2013

openlmi-reviews@lists.fedorahosted.org

2 participants
127 discussions

Start a nNew thread

Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher 04 Jun '14

04 Jun '14

1 27

Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher 17 Jan '14

17 Jan '14

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/314/ ----------------------------------------------------------- (Updated July 3, 2013, 12:03 p.m.) Status ------ This change has been marked as submitted. Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Add .reviewboardrc configuration file Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files. Diffs ----- .gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f .reviewboardrc PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/ Testing ------- Submitted this review via post-review using this configuration file. Thanks, Stephen Gallagher

1 2

Review Request 854: [1/1] Account: Added QA test for account provider.
by Stephen Gallagher 25 Nov '13

25 Nov '13

1 17

Review Request 874: [1/1] Account: Better failure check of lock pool initialization.
by Stephen Gallagher 25 Nov '13

25 Nov '13

1 12

Review Request 710: First upstream test for OpenLMI-Service provider.
by Stephen Gallagher 25 Nov '13

25 Nov '13

1 3

Review Request 845: [1/1] Software: First upstream test for software provider from QA.
by Stephen Gallagher 16 Oct '13

16 Oct '13

1 4

Review Request 902: journald: Add tests for new records writing
by Stephen Gallagher 09 Oct '13

09 Oct '13

1 4

Review Request 875: journald: Support writing new records
by Stephen Gallagher 09 Oct '13

09 Oct '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/875/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- journald: Support writing new records This change adds ability to report new messages in the journal log. This is done by the LMI_JournalLogRecord.CreateInstance() method call taking only CreationClassName, LogCreationClassName, LogName and DataFormat key properties as mandatory, with no need to specify the MessageTimestamp and RecordID key properties. The returned instance will contain all the information with actual RecordID key property of the new record. As long as sd_journal_send() actually only queues the request, we need to watch for journal changes in order to find the new record. This is quite unfortunate as the daemon could be busy and we can't wait forever. Messages are available immediately usually, a timeout is set to 5 seconds for the moment. Record matching is done by comparing the message itself, the origin function name and PID. This brings sufficient amount of confidence though more sophisticated approach may be needed in future to ensure fiull uniqueness. Diffs ----- src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION src/journald/instutil.h PRE-CREATION src/journald/instutil.c PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/875/diff/ Testing ------- Thanks, Tomáš Bžatek

1 5

Review Request 852: journald: Update tests to match modified message format
by Stephen Gallagher 08 Oct '13

08 Oct '13

1 2

Review Request 847: journald: Add iterator tests
by Stephen Gallagher 08 Oct '13

08 Oct '13

1 7

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews September 2013