Review Request 1147: [1/1] software - tests: software test suite with basic tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
9 years, 5 months
Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 11 months
Re: Review Request 314: [openlmi-storage] Add .reviewboardrc configuration file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/314/
-----------------------------------------------------------
(Updated July 3, 2013, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add .reviewboardrc configuration file
Also removes the overly-agressive .* entry in .gitignore, since it prevents updates to the .gitignore and .reviewboardrc files.
Diffs
-----
.gitignore 5c8cb4947de0a5845db267b5490de2bd29f4b35f
.reviewboardrc PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/314/diff/
Testing
-------
Submitted this review via post-review using this configuration file.
Thanks,
Stephen Gallagher
10 years, 3 months
Review Request 1172: Hardware: Added Physical Disk Provider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1172/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added Physical Disk Provider
New Provider:
* LMI_DiskPhysicalPackage
Diffs
-----
mof/60_LMI_Hardware.mof 74e1ee5afc422506ca6769d025bfa4a4dedbd9f3
openlmi-providers.spec 7b3a95ecaf320c86f0af2f7544e006da3c01e855
src/hardware/CMakeLists.txt 8ccf649765ca98e8ca100d9ace454a0dc96f9721
src/hardware/LMI_DiskPhysicalPackageProvider.c PRE-CREATION
src/hardware/LMI_Hardware.h 0ea623768b418b33cec91ec485664b9f3993c0e9
src/hardware/dmidecode.h d139f38d56a13a5e17aab79c303e725cf235f610
src/hardware/smartctl.h PRE-CREATION
src/hardware/smartctl.c PRE-CREATION
src/hardware/sysfs.h 6ff7085d11def60f18b0c814addba79d038b2f52
src/hardware/sysfs.c 4410ff716a566c217fc674b69a6d8a71b4900182
Diff: http://reviewboard-openlmi.rhcloud.com/r/1172/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 6 months
Review Request 1170: providers-tests [4/5] software: refactored tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1170/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software: refactored tests
Base software tests on LmiTestCase from lmi.test.base. Use lmi.shell
abstractions instead of plain pywbem.
Diffs
-----
src/software/test/base.py 35e437a65713cfdc5798f928a1e479eec14f3c9a
src/software/test/test_hosted_software_collection.py 6f4adc31cc81e6489029f792bf045e94e226ccf6
src/software/test/test_hosted_software_identity_resource.py df4b11ff096360d8008f0958c7a6233bf58aa28c
src/software/test/test_installed_software_identity.py 31bbd1cdb373f621d9ce53f12b7406cc08ef6f40
src/software/test/test_member_of_software_collection.py 207937c0fbcb58705e572e7c12f9f779cf152f83
src/software/test/test_resource_for_software_identity.py 39bbfb290a33b74d64c8cebf8693ea57f817b688
src/software/test/test_software_identity.py ea60afebe7ad99b30f865b14d3f16cc03944e940
src/software/test/test_software_identity_checks.py e7d364b2d150ca1b220754539cd79113ebaca6af
src/software/test/test_software_identity_file_check.py 96e086d21e4a5e8acbe0aeead4b5d5ffdf155cca
src/software/test/test_software_identity_resource.py d321523173b54bc5db711af738beb5af4c70eaf8
src/software/test/test_system_software_collection.py bf33c562c1241249c570f609dc3a571a22d4af3a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1170/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 6 months