Review Request 1506: lmishell, convert strings to unicode when working with LMIInstance(Name)s
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1506/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings. Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs -----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478 cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing -------
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1506/#review2208 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Jan. 31, 2014, 2:53 p.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1506/
(Updated Jan. 31, 2014, 2:53 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings. Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478 cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1506/ -----------------------------------------------------------
(Updated June 26, 2014, 8:08 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings. Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs -----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478 cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing -------
Thanks,
Peter Hatina
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher