openlmi-reviews November 2013

openlmi-reviews@lists.fedorahosted.org

2 participants
484 discussions

Start a nNew thread

Review Request 1189: networking [1/1] Prepare 0.2.1 release
by Stephen Gallagher 04 Nov '13

04 Nov '13

1 2

Review Request 1197: providers [1/1] Prepare 0.4.1 release
by Stephen Gallagher 04 Nov '13

04 Nov '13

1 5

Review Request 1190: providers [1/1] Fix coverity issues
by Stephen Gallagher 04 Nov '13

04 Nov '13

1 8

Review Request 1195: providers [1/1] power: Use logind instead of upower
by Stephen Gallagher 04 Nov '13

04 Nov '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1195/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- power: Use logind instead of upower Diffs ----- README 66fe91f03cce45b34062246929121546497e1c42 openlmi-providers.spec 7b3a95ecaf320c86f0af2f7544e006da3c01e855 src/power/CMakeLists.txt 42e001f28db1186e40af9a87c20c64e0f14dd5d9 src/power/power.c 96960be423779163ed14596626a5cf393ea3fe96 tools/gendoc/gendoc 436407a3871ff730c74ed0722b71ba42b4279f3f Diff: http://reviewboard-openlmi.rhcloud.com/r/1195/diff/ Testing ------- Thanks, Radek Novacek

1 2

Review Request 1199: providers [2/2] software: skip unreliable tests
by Stephen Gallagher 04 Nov '13

04 Nov '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1199/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software: skip unreliable tests Few tests of LMI_SoftwareIdentityFileCheck are not reliable on randomly selected package. Let's skip them temporarily. Diffs ----- src/software/test/test_software_identity_file_check.py 9df54ab9495acd356319c11b101704544391c147 Diff: http://reviewboard-openlmi.rhcloud.com/r/1199/diff/ Testing ------- Thanks, Michal Minar

1 2

Review Request 1198: providers [1/2] software: fixed SoftwareIdentityFileCheck
by Stephen Gallagher 04 Nov '13

04 Nov '13

1 2

buildbot failure in OpenLMI on providers-rhel7
by openlmiproject＠gmail.com 04 Nov '13

04 Nov '13

The Buildbot has detected a failed build on builder providers-rhel7 while building providers. Full details are available at: http://openlmi-rnovacek.rhcloud.com/builders/providers-rhel7/builds/177 Buildbot URL: http://openlmi-rnovacek.rhcloud.com/ Buildslave for this Build: rhel7-slave Build Reason: scheduler Build Source Stamp: [branch master] 8e8c32b6a1f9332eaf3697fc3dd8e2a6ead397ec Blamelist: Tomas Bzatek <tbzatek(a)redhat.com> BUILD FAILED: failed tests selinux check sincerely, -The Buildbot

1 0

Review Request 1196: indmanager: Use per-instance set of pthread stuff
by Stephen Gallagher 04 Nov '13

04 Nov '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1196/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- indmanager: Use per-instance set of pthread stuff Can't really have global variables for threads and mutexes as long as there are more indication managers running, simultaneously using the same objects, leading to deadlock in a matter of time. This patch moves the pthread stuff in the IMManager struct which is (usually) speficic to each CIM indication class. Diffs ----- src/indmanager/ind_manager.h b82fa69a45136e114948f8a8c95cf09cb0a8a1e0 src/indmanager/ind_manager.c 525d2f8fd60fb0da49f071d1d90ea578bc95466d Diff: http://reviewboard-openlmi.rhcloud.com/r/1196/diff/ Testing ------- Thanks, Tomáš Bžatek

1 2

buildbot failure in OpenLMI on providers-rhel7
by openlmiproject＠gmail.com 04 Nov '13

04 Nov '13

The Buildbot has detected a failed build on builder providers-rhel7 while building OpenLMI. Full details are available at: http://openlmi-rnovacek.rhcloud.com/builders/providers-rhel7/builds/176 Buildbot URL: http://openlmi-rnovacek.rhcloud.com/ Buildslave for this Build: rhel7-slave Build Reason: A build was forced by 'openlmi <openlmi@localhost>': force build Build Source Stamp: HEAD Blamelist: BUILD FAILED: failed tests selinux check sincerely, -The Buildbot

1 0

Review Request 1193: lmishell, fix str(LMIInstance) and str(LMIInstanceName)
by Stephen Gallagher 04 Nov '13

04 Nov '13

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1193/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- print str(lmi_instance) print str(lmi_instance_name) -> both classes define __str__() method, which returns a string with serialized key properties. This should make debugging of scripts easier. Diffs ----- cli/lmi/shell/LMIInstance.py 14af4d106bdc9b1c7d24709a6b7d155f07482d58 cli/lmi/shell/LMIInstanceName.py ca8a3b0d5061142e85446045bc4de3cdb6b72e1f Diff: http://reviewboard-openlmi.rhcloud.com/r/1193/diff/ Testing ------- Thanks, Peter Hatina

1 3

← Newer
1
...
38
39
40
41
42
43
44
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews November 2013