----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1728/#review2626 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On May 14, 2014, 4:22 p.m., Tomáš Bžatek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1728/
(Updated May 14, 2014, 4:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
According to the Simple Identity Management Profile (DSP1034) document the LMI_Account.UserPassword property should not contain the password itself, no matter how encrypted it is. It should either contain an array of zero elements when password has been set or NULL when password is missing or not configured.
Another change this commit brings is a more precise behaviour of LMI_Account.ModifyInstance() method. When the UserPassword property is array of zero elements, no change regarding password is made. This case was previously treated as a request for password removal. The DSP1034 profile doesn't specify such scenario, let's treat it the same way as the GetInstance() operation.
Diffs
mof/60_LMI_Account.mof 6bc99c8cbea85b556cfcb073af08e63c089791d9 src/account/LMI_AccountProvider.c fdb06fffe99198b469def5de91508a766a6a7ecf
Diff: http://reviewboard-openlmi.rhcloud.com/r/1728/diff/
Testing
Thanks,
Tomáš Bžatek