----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1258/#review1733 -----------------------------------------------------------

Ship it!

Ship It!

- Jan Safranek

On Nov. 18, 2013, 6:29 p.m., Peter Schiffer wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1258/

---

(Updated Nov. 18, 2013, 6:29 p.m.)

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description

Hardware: Added LMI_DiskPhysicalPackageContainer association

Added LMI_DiskPhysicalPackageContainer association between LMI_DiskPhysicalPackage and LMI_Chassis.

Also, added default values for disk manufacturer and model.

Diffs

mof/60_LMI_Hardware.mof 342f0e3fc6f96958e5c53852521ccf1efc266151 src/hardware/LMI_DiskPhysicalPackageContainerProvider.c PRE-CREATION src/hardware/lsblk.c 74d4a2fcea69a2df32bd1b5ddcf4b5caa40cbf7a src/hardware/smartctl.c 8ba724abf01c129c712d5aae0563acf5324723cd

Diff: http://reviewboard-openlmi.rhcloud.com/r/1258/diff/

Testing

Thanks,

Peter Schiffer