----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/ -----------------------------------------------------------
(Updated Aug. 30, 2013, 11:35 a.m.)
Review request for OpenLMI Developers.
Changes -------
MOF documentation fix.
Repository: openlmi-providers
Description -------
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs (updated) -----
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/ -----------------------------------------------------------
(Updated Aug. 30, 2013, 3:27 p.m.)
Review request for OpenLMI Developers.
Changes -------
Use correct return statuses.
Repository: openlmi-providers
Description -------
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs (updated) -----
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/ -----------------------------------------------------------
(Updated Aug. 30, 2013, 3:36 p.m.)
Review request for OpenLMI Developers.
Changes -------
Use uppercase F for force parameter.
Repository: openlmi-providers
Description -------
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs (updated) -----
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/#review1039 -----------------------------------------------------------
mof/60_LMI_Account.mof http://reviewboard-openlmi.rhcloud.com/r/791/#comment572
"primary group are *deleted*" ?
- Michal Minar
On Aug. 30, 2013, 3:36 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/
(Updated Aug. 30, 2013, 3:36 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing
Thanks,
Roman Rakus
On Sept. 2, 2013, 6:33 a.m., Michal Minar wrote:
mof/60_LMI_Account.mof, line 50 http://reviewboard-openlmi.rhcloud.com/r/791/diff/4/?file=4422#file4422line50
"primary group are *deleted*" ?
Fixed
- Roman
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/#review1039 -----------------------------------------------------------
On Aug. 30, 2013, 3:36 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/
(Updated Aug. 30, 2013, 3:36 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/#review1040 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Aug. 30, 2013, 3:36 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/
(Updated Aug. 30, 2013, 3:36 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/ -----------------------------------------------------------
(Updated Sept. 2, 2013, 7:35 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/#review1053 -----------------------------------------------------------
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment580
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment581
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment582
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment583
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment584
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment585
Use constants please.
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/791/#comment586
Use constants please.
- Jan Safranek
On Sept. 2, 2013, 9:35 a.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/
(Updated Sept. 2, 2013, 9:35 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing
Thanks,
Roman Rakus
openlmi-reviews@lists.fedorahosted.org